Skip to content

Visualizing gaussian splats #7194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 32 commits into from
Apr 1, 2025
Merged

Conversation

billamiable
Copy link
Contributor

@billamiable billamiable commented Mar 8, 2025

Type

  • Bug fix (non-breaking change which fixes an issue): Fixes #
  • New feature (non-breaking change which adds functionality). Resolves #
  • Breaking change (fix or feature that would cause existing functionality to not work as expected) Resolves #

Motivation and Context

This PR, along with two other PRs (#7192, #7193), will fix #7154

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • This PR changes Open3D behavior or adds new functionality.
    • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
      updated accordingly.
    • I have added or updated C++ and / or Python unit tests OR included test
      results
      (e.g. screenshots or numbers) here.
  • I will follow up and update the code if CI fails.
  • For fork PRs, I have selected Allow edits from maintainers.

Description

Copy link

update-docs bot commented Mar 8, 2025

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

Copy link
Contributor

@benjaminum benjaminum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Please have a look at the comments

@billamiable billamiable changed the title Doc for visualizing gaussian splats Visualizing gaussian splats Mar 12, 2025
@@ -1413,9 +1413,10 @@ int PointCloud::GaussianSplatGetSHOrder() const {
"SH degree higher than 2 is not supported. The SH degree "
"of in input data is {}, we set it as 2.",
deg);
deg = 2;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @billamiable we don't support sh degree > 2 for rendering, but we do support it for other operations (reading and writing 3DGS files, and in the future editing 3DGS data). I would skip this warning here, and instead only add it if the user tries to display a 3DGS point cloud with 3 or higher degree.

@ssheorey ssheorey force-pushed the doc-gaussian-rendering branch from 66b145a to 4c8fa71 Compare March 31, 2025 22:02
@ssheorey ssheorey merged commit bb30376 into isl-org:main Apr 1, 2025
31 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Visualize 3D Gaussian splats
4 participants