-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Visualizing gaussian splats #7194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
will create a new PR for this
Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Please have a look at the comments
cpp/open3d/visualization/rendering/filament/GaussianSplatBuffers.cpp
Outdated
Show resolved
Hide resolved
cpp/open3d/visualization/rendering/filament/GaussianSplatBuffers.cpp
Outdated
Show resolved
Hide resolved
cpp/open3d/visualization/rendering/filament/GaussianSplatBuffers.cpp
Outdated
Show resolved
Hide resolved
cpp/open3d/visualization/rendering/filament/GaussianSplatBuffers.cpp
Outdated
Show resolved
Hide resolved
cpp/open3d/visualization/rendering/filament/GaussianSplatBuffers.cpp
Outdated
Show resolved
Hide resolved
cpp/open3d/visualization/rendering/filament/GaussianSplatBuffers.cpp
Outdated
Show resolved
Hide resolved
cpp/open3d/visualization/rendering/filament/GaussianSplatBuffers.cpp
Outdated
Show resolved
Hide resolved
cpp/open3d/t/geometry/PointCloud.cpp
Outdated
@@ -1413,9 +1413,10 @@ int PointCloud::GaussianSplatGetSHOrder() const { | |||
"SH degree higher than 2 is not supported. The SH degree " | |||
"of in input data is {}, we set it as 2.", | |||
deg); | |||
deg = 2; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @billamiable we don't support sh degree > 2 for rendering, but we do support it for other operations (reading and writing 3DGS files, and in the future editing 3DGS data). I would skip this warning here, and instead only add it if the user tries to display a 3DGS point cloud with 3 or higher degree.
66b145a
to
4c8fa71
Compare
Type
Motivation and Context
This PR, along with two other PRs (#7192, #7193), will fix #7154
Checklist:
python util/check_style.py --apply
to apply Open3D code styleto my code.
updated accordingly.
results (e.g. screenshots or numbers) here.
Description