Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI ARM #7196

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

CI ARM #7196

wants to merge 18 commits into from

Conversation

johnnynunez
Copy link

This pull request includes significant updates to the .github/workflows/ubuntu-openblas.yml file, focusing on updating the Docker build and test processes, as well as removing unnecessary steps related to the ARM64 job.

Key changes include:

Docker Build and Test Updates:

  • Updated the Docker build and test scripts to use openblas-amd64-py312-dev instead of openblas-amd64-py310-dev.

ARM64 Job Simplification:

  • Removed the skip-arm64-check-on-fork job and its associated steps, simplifying the workflow.
  • Changed the runs-on parameter for the openblas-arm64 job to use ubuntu-24.04-arm instead of ubuntu-latest.
  • Removed the complex steps for creating and managing a VM for the ARM64 job, replacing them with Docker build and test steps similar to the AMD64 job.

Copy link

update-docs bot commented Mar 8, 2025

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

@ssheorey ssheorey self-requested a review March 12, 2025 00:23
Copy link
Member

@ssheorey ssheorey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @johnnynunez, this is really useful! Please see my comments below.

@johnnynunez johnnynunez requested a review from ssheorey March 17, 2025 06:48
@ssheorey
Copy link
Member

Hi @johnnynunez please take a look at the ARM64 CI errors. You can ignore the Windows CI errors, they are unrelated.

2025-03-17T22:59:14.7432487Z #21 2221.1 [ 74%] Linking CXX executable ../../OfflineReconstruction/OfflineReconstruction
2025-03-17T22:59:15.0347566Z #21 2221.4 [ 74%] Building CXX object cpp/tests/CMakeFiles/tests.dir/core/EigenConverter.cpp.o
2025-03-17T22:59:17.4662031Z #21 2223.8 [ 74%] Linking CXX executable ../../bin/examples/CameraPoseTrajectory
2025-03-17T22:59:18.1026626Z #21 2224.3 /usr/bin/ld: ../../curl/lib/libcurl.a(idn.c.o): in function `Curl_idn_decode':
2025-03-17T22:59:18.1027580Z #21 2224.3 idn.c:(.text+0x58): undefined reference to `idn2_check_version'
2025-03-17T22:59:18.1028570Z #21 2224.3 /usr/bin/ld: idn.c:(.text+0x74): undefined reference to `idn2_lookup_ul'
2025-03-17T22:59:18.1029440Z #21 2224.3 /usr/bin/ld: idn.c:(.text+0xa0): undefined reference to `idn2_free'
2025-03-17T22:59:18.1030304Z #21 2224.3 /usr/bin/ld: idn.c:(.text+0xdc): undefined reference to `idn2_lookup_ul'
2025-03-17T22:59:18.1031676Z #21 2224.3 /usr/bin/ld: ../../curl/lib/libcurl.a(idn.c.o): in function `Curl_free_idnconverted_hostname':
2025-03-17T22:59:18.1032558Z #21 2224.3 idn.c:(.text+0x120): undefined reference to `idn2_free'
2025-03-17T22:59:18.1033424Z #21 2224.3 /usr/bin/ld: ../../curl/lib/libcurl.a(idn.c.o): in function `Curl_idnconvert_hostname':
2025-03-17T22:59:18.1034329Z #21 2224.3 idn.c:(.text+0x1bc): undefined reference to `idn2_check_version'
2025-03-17T22:59:18.1035191Z #21 2224.3 /usr/bin/ld: idn.c:(.text+0x1d4): undefined reference to `idn2_lookup_ul'
2025-03-17T22:59:18.1036058Z #21 2224.3 /usr/bin/ld: idn.c:(.text+0x200): undefined reference to `idn2_lookup_ul'
2025-03-17T22:59:18.1036800Z #21 2224.3 collect2: error: ld returned 1 exit status
2025-03-17T22:59:18.1038096Z #21 2224.3 make[2]: *** [cpp/apps/CMakeFiles/OfflineReconstruction.dir/build.make:163: OfflineReconstruction/OfflineReconstruction] Error 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants