Fix Style Check workflow checkout for fork PRs #7387
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The checkout step was using `head.ref` (branch name) without specifying the repository, causing it to look for the branch on isl-org/Open3D instead of the fork. This fails because fork branches don't exist on the upstream repo. Changes: - Add `repository` parameter to checkout from the correct fork - Use `head.sha` instead of `head.ref` for more reliable checkout
|
Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The checkout step was using
head.ref(branch name) without specifying the repository, causing it to look for the branch on isl-org/Open3D instead of the fork. This fails because fork branches don't exist on the upstream repo.Changes:
repositoryparameter to checkout from the correct forkhead.shainstead ofhead.reffor more reliable checkoutType
Motivation and Context
Checklist:
python util/check_style.py --applyto apply Open3D code styleto my code.
updated accordingly.
results (e.g. screenshots or numbers) here.
Description