Fix ROI UAF cluster and bump Emscripten INITIAL_MEMORY to 128 MB#807
Merged
Conversation
ROI UAF fixes: - LegoAnimActorStruct deep-copies m_roiMap and deletes copy-assignment, so LegoExtraActor's copy-construction at legoextraactor.cpp no longer shares ownership with the source presenter. - LegoROI tracks slot back-references; its destructor nulls every registered LegoROI** so per-element UAF in arrays like LegoAnimPresenter::m_roiMap is impossible. LegoAnimActorStruct / LegoAnimPresenter / LegoLocomotionAnimPresenter register and unregister around their array lifetimes. - LegoAnimationManager::Suspend now invokes ClearMaps on every persistent LegoExtraActor (not just those currently in m_extras) so dormant actors cannot retain stale m_AnimTreePtr after world teardown. Adds ClearMaps overrides on Act2Actor, Act3Cop, Act3Brickster, Act3Shark, LegoRaceCar, LegoExtraActor. INITIAL_MEMORY=128mb is re-added to the Emscripten link options.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Collection of fixes based on crash reports collected from isle.pizza - these aren't easily reproducible as they require a lot of of specific game state to build up first.
Fixes a long-running use-after-free cluster in LegoAnimActorStruct::m_roiMap / LegoROI per-element references, plus adds
-sINITIAL_MEMORY=128mb to the Emscripten link options.