ci: suffix debug-build artifacts to avoid release filename collision#808
Merged
foxtacles merged 3 commits intoMay 17, 2026
Merged
Conversation
`actions/download-artifact@v8` with `merge-multiple: true` extracts every artifact into the same Release/ directory in parallel. Release and Debug builds of the same platform produced identical CPack/AppImage filenames (isle-0.1-Windows-x64.zip, isle-0.1-Linux-x64.tar.gz, Isle_Portable-x86_64.AppImage), so the parallel writes raced on the same path and intermittently produced corrupt archives in the release. Append `-debug` to CPACK_PACKAGE_FILE_NAME when ISLE_DEBUG is set, and rename the AppImage in the same case, so each matrix entry contributes a unique filename to the release. Fixes isledecomp#646
Contributor
|
Is I'd get rid of it, and perhaps add a |
…D_DEBUG The Linux (Debug) and MSVC (x64 Debug) jobs only differed from their Release counterparts in -DISLE_DEBUG=ON. ISLE_DEBUG was only consulted in one place: miniwin/CMakeLists.txt for the Nintendo 3DS citro3d library selection (citro3dd vs citro3d) — which the Nintendo 3DS matrix row never enabled. So Linux (Debug)/MSVC (x64 Debug) produced binaries identical to their Release builds and collided with them in the release artifact merge, which is what corrupted isledecomp#646. Drop the two duplicate matrix entries and the now-unused ISLE_DEBUG plumbing, and reintroduce the 3DS knob as ISLE_CITRO3D_DEBUG scoped to its actual use site. Reverts the -debug filename suffix added in the previous commit; with the duplicates gone there is nothing left to disambiguate. Fixes isledecomp#646
… manifest These passed -DISLE_DEBUG=OFF, which is now an unknown CMake variable.
madebr
approved these changes
May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
actions/download-artifact@v8withmerge-multiple: trueextracts every artifact into the same Release/ directory in parallel. Release and Debug builds of the same platform produced identical CPack/AppImage filenames (isle-0.1-Windows-x64.zip, isle-0.1-Linux-x64.tar.gz, Isle_Portable-x86_64.AppImage), so the parallel writes raced on the same path and intermittently produced corrupt archives in the release.Append
-debugto CPACK_PACKAGE_FILE_NAME when ISLE_DEBUG is set, and rename the AppImage in the same case, so each matrix entry contributes a unique filename to the release.Fixes #646