feat: exclude invisible and cloned slides from tab navigation (#521) #535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…9k#521) Prevent invisible carousel slides from receiving keyboard focus via tab navigation by setting tabindex="-1". This addresses an accessibility issue where aria-hidden slides could still be focused, causing confusion for keyboard and assistive technology users. Changes: - Add tabindex="-1" to all non-visible slides (those outside visibleRange) - Add tabindex="-1" to all cloned slides (used in wrapAround mode) - Add test cases to verify invisible and cloned slides cannot be tabbed to - Update snapshots to reflect new tabindex attribute This ensures that only visible carousel items are reachable via keyboard navigation, providing a better experience for keyboard and screen reader users. Fixes ismail9k#521
Owner
|
Thank you for your contribution 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Exclude invisible slides from keyboard focus (fix #521)
Summary
tabindex="-1"to any Carousel slide that’s either cloned or outside the currentvisibleRangeso hidden items can’t be tabbedaria-hiddenbehavior for clones and reuse the new tab logic for all hidden slidesRelated Issues
Testing