chore: update GitHub OIDC deploy role #1472
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR corrects the staging deployment role name and updates the AWS credentials action version.
- Fixed staging deploy role name from
isomer-infra-stg-deploy-roletoisomer-infra-staging-deploy-rolefor consistency with the production naming pattern - Partially upgraded
aws-actions/configure-aws-credentialsfrom v2 to v4
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/deploy_staging.yml |
Updated staging deploy role name in both deploy-app and deploy-support jobs to use the correct isomer-infra-staging-deploy-role name |
.github/workflows/aws_deploy.yml |
Updated aws-actions/configure-aws-credentials from v2 to v4 in the build job |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Incorrect deploy role name for staging.
Solution
Breaking Changes
Bug Fixes: