Add e2e test for [not] pruning remote revisions #658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nick Fox <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #658 +/- ##
==========================================
+ Coverage 74.28% 74.57% +0.28%
==========================================
Files 42 42
Lines 2559 2584 +25
==========================================
+ Hits 1901 1927 +26
Misses 565 565
+ Partials 93 92 -1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Nick Fox <[email protected]>
| g.Expect(clPrimary.List(ctx, gatewayPods, client.InNamespace(controlPlaneNamespace), client.MatchingLabels{"istio": "eastwestgateway"})).To(Succeed()) | ||
| for _, pod := range gatewayPods.Items { | ||
| g.Expect(pod.DeletionTimestamp).To(BeNil()) | ||
| g.Expect(pod).To(HaveCondition(corev1.PodReady, metav1.ConditionTrue), "Pod is not Ready in sample namespace; unexpected Condition") |
There was a problem hiding this comment.
Do you think we should log the current state of the pod here when we hit this error?
There was a problem hiding this comment.
Yes that would be helpful. I'll add that.
There was a problem hiding this comment.
Not the most readable output but now it will print the pod status struct:
Pod is not Ready in sample namespace; unexpected Condition. Pod status: v1.PodStatus{Phase:"Running", Conditions:[]v1.PodCondition{v1.PodCondition{Type:"PodReadyToStartContainers", Status:"True", LastProbeTime:time.Date(1, time.January, 1, 0, 0, 0, 0, time.UTC), LastTransitionTim
e:time.Date(2025, time.February, 18, 14, 26, 39, 0, time.Local), Reason:"", Message:""}, v1.PodCondition{Type:"Initialized", Status:"True", LastProbeTime:time.Date(1, time.January, 1, 0, 0, 0, 0, time.UTC), LastTransitionTime:time.Date(2025, time.February, 18, 14, 26, 40, 0, time.L
ocal), Reason:"", Message:""}, v1.PodCondition{Type:"Ready", Status:"True", LastProbeTime:time.Date(1, time.January, 1, 0, 0, 0, 0, time.UTC), LastTransitionTime:time.Date(2025, time.February, 18, 14, 26, 42, 0, time.Local), Reason:"", Message:""}, v1.PodCondition{Type:"ContainersR
eady", Status:"True", LastProbeTime:time.Date(1, time.January, 1, 0, 0, 0, 0, time.UTC), LastTransitionTime:time.Date(2025, time.February, 18, 14, 26, 42, 0, time.Local), Reason:"", Message:""}, v1.PodCondition{Type:"PodScheduled", Status:"True", LastProbeTime:time.Date(1, time.Jan
uary, 1, 0, 0, 0, 0, time.UTC), LastTransitionTime:time.Date(2025, time.February, 18, 14, 26, 38, 0, time.Local), Reason:"", Message:""}}, Message:"", Reason:"", NominatedNodeName:"", HostIP:"172.18.0.3", HostIPs:[]v1.HostIP{v1.HostIP{IP:"172.18.0.3"}}, PodIP:"10.10.0.11", PodIPs:[
]v1.PodIP{v1.PodIP{IP:"10.10.0.11"}}, StartTime:time.Date(2025, time.February, 18, 14, 26, 38, 0, time.Local), InitContainerStatuses:[]v1.ContainerStatus{v1.ContainerStatus{Name:"istio-init", State:v1.ContainerState{Waiting:(*v1.ContainerStateWaiting)(nil), Running:(*v1.ContainerSt
ateRunning)(nil), Terminated:(*v1.ContainerStateTerminated)(0xc000391d50)}, LastTerminationState:v1.ContainerState{Waiting:(*v1.ContainerStateWaiting)(nil), Running:(*v1.ContainerStateRunning)(nil), Terminated:(*v1.ContainerStateTerminated)(nil)}, Ready:true, RestartCount:0, Image:
"gcr.io/istio-release/proxyv2:1.24.2", ImageID:"gcr.io/istio-release/proxyv2@sha256:445156b5f4a780242d079a47b7d88199cbbb5959c92358469b721af490eca1ae", ContainerID:"containerd://d09ccac93a0db514809bf048282cc20c3a45da1b21cea78a31e232407bff680a", Started:(*bool)(0xc0008b7918), Allocat
edResources:v1.ResourceList(nil), Resources:(*v1.ResourceRequirements)(nil), VolumeMounts:[]v1.VolumeMountStatus{v1.VolumeMountStatus{Name:"kube-api-access-v9t4v", MountPath:"/var/run/secrets/kubernetes.io/serviceaccount", ReadOnly:true, RecursiveReadOnly:(*v1.RecursiveReadOnlyMode
)(0xc000355120)}}, User:(*v1.ContainerUser)(nil), AllocatedResourcesStatus:[]v1.ResourceStatus(nil)}}, ContainerStatuses:[]v1.ContainerStatus{v1.ContainerStatus{Name:"helloworld", State:v1.ContainerState{Waiting:(*v1.ContainerStateWaiting)(nil), Running:(*v1.ContainerStateRunning)(
0xc000e13e18), Terminated:(*v1.ContainerStateTerminated)(nil)}, LastTerminationState:v1.ContainerState{Waiting:(*v1.ContainerStateWaiting)(nil), Running:(*v1.ContainerStateRunning)(nil), Terminated:(*v1.ContainerStateTerminated)(nil)}, Ready:true, RestartCount:0, Image:"quay.io/sai
l-dev/examples-helloworld-v1:1.0", ImageID:"quay.io/sail-dev/examples-helloworld-v1@sha256:328b237e4fb1b551dddbc6b4920ec6d0c0d1e7a6f18861398ac54f9df3d466f8", ContainerID:"containerd://5640b80b10eaeafed1bd4f2803f901717f8358502e146a91ba069e20b8e56548", Started:(*bool)(0xc0008b783a),
AllocatedResources:v1.ResourceList(nil), Resources:(*v1.ResourceRequirements)(nil), VolumeMounts:[]v1.VolumeMountStatus{v1.VolumeMountStatus{Name:"kube-api-access-v9t4v", MountPath:"/var/run/secrets/kubernetes.io/serviceaccount", ReadOnly:true, RecursiveReadOnly:(*v1.RecursiveReadO
nlyMode)(0xc000355100)}}, User:(*v1.ContainerUser)(nil), AllocatedResourcesStatus:[]v1.ResourceStatus(nil)}, v1.ContainerStatus{Name:"istio-proxy", State:v1.ContainerState{Waiting:(*v1.ContainerStateWaiting)(nil), Running:(*v1.ContainerStateRunning)(0xc000e13e30), Terminated:(*v1.C
ontainerStateTerminated)(nil)}, LastTerminationState:v1.ContainerState{Waiting:(*v1.ContainerStateWaiting)(nil), Running:(*v1.ContainerStateRunning)(nil), Terminated:(*v1.ContainerStateTerminated)(nil)}, Ready:true, RestartCount:0, Image:"gcr.io/istio-release/proxyv2:1.24.2", Image
ID:"gcr.io/istio-release/proxyv2@sha256:445156b5f4a780242d079a47b7d88199cbbb5959c92358469b721af490eca1ae", ContainerID:"containerd://8d50eefca3557831de33cbc206240dfdd9c23cf4fc6235d5c668e4577100c11f", Started:(*bool)(0xc0008b7868), AllocatedResources:v1.ResourceList(nil), Resources:
(*v1.ResourceRequirements)(nil), VolumeMounts:[]v1.VolumeMountStatus{v1.VolumeMountStatus{Name:"workload-socket", MountPath:"/var/run/secrets/workload-spiffe-uds", ReadOnly:false, RecursiveReadOnly:(*v1.RecursiveReadOnlyMode)(nil)}, v1.VolumeMountStatus{Name:"credential-socket", Mo
untPath:"/var/run/secrets/credential-uds", ReadOnly:false, RecursiveReadOnly:(*v1.RecursiveReadOnlyMode)(nil)}, v1.VolumeMountStatus{Name:"workload-certs", MountPath:"/var/run/secrets/workload-spiffe-credentials", ReadOnly:false, RecursiveReadOnly:(*v1.RecursiveReadOnlyMode)(nil)},
v1.VolumeMountStatus{Name:"istiod-ca-cert", MountPath:"/var/run/secrets/istio", ReadOnly:false, RecursiveReadOnly:(*v1.RecursiveReadOnlyMode)(nil)}, v1.VolumeMountStatus{Name:"istio-data", MountPath:"/var/lib/istio/data", ReadOnly:false, RecursiveReadOnly:(*v1.RecursiveReadOnlyMod
e)(nil)}, v1.VolumeMountStatus{Name:"istio-envoy", MountPath:"/etc/istio/proxy", ReadOnly:false, RecursiveReadOnly:(*v1.RecursiveReadOnlyMode)(nil)}, v1.VolumeMountStatus{Name:"istio-token", MountPath:"/var/run/secrets/tokens", ReadOnly:false, RecursiveReadOnly:(*v1.RecursiveReadOn
lyMode)(nil)}, v1.VolumeMountStatus{Name:"istio-podinfo", MountPath:"/etc/istio/pod", ReadOnly:false, RecursiveReadOnly:(*v1.RecursiveReadOnlyMode)(nil)}, v1.VolumeMountStatus{Name:"kube-api-access-v9t4v", MountPath:"/var/run/secrets/kubernetes.io/serviceaccount", ReadOnly:true, Re
cursiveReadOnly:(*v1.RecursiveReadOnlyMode)(0xc000355110)}}, User:(*v1.ContainerUser)(nil), AllocatedResourcesStatus:[]v1.ResourceStatus(nil)}}, QOSClass:"Burstable", EphemeralContainerStatuses:[]v1.ContainerStatus(nil), Resize:"", ResourceClaimStatuses:[]v1.PodResourceClaimStatus(
nil)}
There was a problem hiding this comment.
Yeah, this is too verbose. I'm fine if you want to revert this change.
Looks like there is some valid error in e2e-kind-multicluster_sail-operator_main suite.
[FAILED] Timed out after 180.000s.
The function passed to Eventually failed at /home/prow/go/src/github.com/istio-ecosystem/sail-operator/tests/e2e/multicluster/multicluster_primaryremote_test.go:440 with:
Expected
<string>: default
to equal
<string>: default-v1-24-1
In [BeforeAll] at: /home/prow/go/src/github.com/istio-ecosystem/sail-operator/tests/e2e/multicluster/multicluster_primaryremote_test.go:339 @ 02/18/25 20:00:42.857
Co-authored-by: Sridhar Gaddam <[email protected]> Signed-off-by: Nick Fox <[email protected]>
Signed-off-by: Nick Fox <[email protected]>
nrfox
force-pushed
the
e2e-test-for-pruning
branch
from
18fe1c4 to
5045cfa
Compare
|
@nrfox: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
The following test is failing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Adds e2e test for #654
Which issue(s) this PR fixes:
Fixes #
Related Issue/PR #
Relates to #654
Additional information: