Skip to content

[WIP] add draft SEP for base chart handling #787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dgn
Copy link
Collaborator

@dgn dgn commented Apr 17, 2025

this is mainly for discussion of how to address #749 and potential other issues

cc @luksa

@dgn
Copy link
Collaborator Author

dgn commented Apr 23, 2025

/retest

Copy link

codecov bot commented Apr 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.46%. Comparing base (4a06ad0) to head (4512f96).
Report is 5 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (4a06ad0) and HEAD (4512f96). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (4a06ad0) HEAD (4512f96)
2 1
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #787      +/-   ##
==========================================
- Coverage   76.51%   70.46%   -6.06%     
==========================================
  Files          44       38       -6     
  Lines        2623     2089     -534     
==========================================
- Hits         2007     1472     -535     
+ Misses        530      493      -37     
- Partials       86      124      +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants