Implement istiobase controller

[luksa]

The istiobase controller manages the application of the base chart. As only one instance of this chart can be installed at once, this has to be done by a new controller. If we had added the rendering of this chart to the istiorevision controller, we could have two instances of that controller both trying to update the chart/release.

Addresses #749

[luksa]

Needs #801

[codecov]

Codecov Report

Attention: Patch coverage is 3.49650% with 138 lines in your changes missing coverage. Please review.

Project coverage is 48.90%. Comparing base (ac14e1d) to head (8a039d2).

Files with missing lines	Patch %	Lines
controllers/istiobase/istiobase_controller.go	0.00%	120 Missing ⚠️
pkg/helm/chartmanager.go	0.00%	8 Missing ⚠️
cmd/main.go	0.00%	6 Missing ⚠️
controllers/istiocni/istiocni_controller.go	0.00%	1 Missing ⚠️
...trollers/istiorevision/istiorevision_controller.go	0.00%	1 Missing ⚠️
...rs/istiorevisiontag/istiorevisiontag_controller.go	0.00%	1 Missing ⚠️
controllers/ztunnel/ztunnel_controller.go	0.00%	1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (ac14e1d) and HEAD (8a039d2). Click for more details.

HEAD has 1 upload less than BASE

Flag	BASE (ac14e1d)	HEAD (8a039d2)
	2	1

Additional details and impacted files

@@             Coverage Diff             @@
##             main     #802       +/-   ##
===========================================
- Coverage   76.36%   48.90%   -27.47%     
===========================================
  Files          44       45        +1     
  Lines        2636     2773      +137     
===========================================
- Hits         2013     1356      -657     
- Misses        535     1352      +817     
+ Partials       88       65       -23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[nrfox]

LGTM, do we need any tests for this?

[luksa]

/retest

[dgn]

LGTM, do we need any tests for this?

I was about to write the same comment, some tests would be good

[luksa]

Yeah, I'm just about done with the tests.

[luksa]

/retest

[luksa]

/retest

[luksa]

Not sure what's up with the integration test coverage job, because the integration tests pass fine when you run them locally (and in CI). There is a strange error message related to the revisiontag controller:

 2025-04-30T14:15:40Z	ERROR	ctrlr.revtag	Reconciler error	{"IstioRevisionTag": "default", "reconcileID": "5ca78ebf-7352-4088-9039-a474e9bed946", "error": "failed to uninstall Helm chart \"revisiontags\": uninstallation completed with 1 error(s): uninstall: Failed to purge the release: release: not found"}

[dgn]

/test all

[istio-testing]

@luksa: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
integ-tests-arm64_sail-operator_main	8a039d2	link	true	/test integ-tests-arm64
docs-test_sail-operator_main	8a039d2	link	false	/test docs-test
e2e-kind-multicluster_sail-operator_main	8a039d2	link	true	/test e2e-kind-multicluster

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.