Skip to content

Update the operator description as it's no longer experimental #836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2025

Conversation

FilipB
Copy link
Collaborator

@FilipB FilipB commented May 21, 2025

No description provided.

@FilipB FilipB requested a review from a team as a code owner May 21, 2025 16:56
Copy link

codecov bot commented May 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.36%. Comparing base (8d728f2) to head (134b795).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #836   +/-   ##
=======================================
  Coverage   76.36%   76.36%           
=======================================
  Files          44       44           
  Lines        2636     2636           
=======================================
  Hits         2013     2013           
  Misses        535      535           
  Partials       88       88           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@@ -12,9 +12,9 @@ csv:
displayName: Sail Operator
categories: OpenShift Optional, Integration & Delivery, Networking, Security
capabilities: Seamless Upgrades
description: Experimental operator for installing Istio service mesh
description: The Sail Operator manages the lifecycle of your Istio control plane. It provides custom resources for you to deploy and manage your control plane components.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description and longDescription seems to be the same - there is no harm in it, just sharing the observation.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Long description also contains list of supported versions and a link to our documentation. Not sure if we want to extend this or this is fine.

@FilipB
Copy link
Collaborator Author

FilipB commented May 22, 2025

/retest

1 similar comment
@fjglira
Copy link
Contributor

fjglira commented May 22, 2025

/retest

@istio-testing
Copy link
Collaborator

istio-testing commented May 22, 2025

@FilipB: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
docs-test_sail-operator_main 134b795 link false /test docs-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@istio-testing istio-testing merged commit ac14e1d into istio-ecosystem:main May 22, 2025
16 of 17 checks passed
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request May 22, 2025
* upstream/main:
  Update the operator description as it's no longer experimental (istio-ecosystem#836)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants