Skip to content

Conversation

@ThomasAFink
Copy link
Member

Pull Request Checklist (Feature Branch to next):

  • Ich habe die neuesten Änderungen aus dem next Branch in meinen Feature-Branch gemergt.
  • Das Code-Review wurde abgeschlossen.
  • Fachliche Tests wurden durchgeführt und sind abgeschlossen.

- Phase 1: Complete table renaming from German to English snake_case
- Renamed 33 database tables from German to English snake_case
- Updated all Query classes to use correct table aliases
- Fixed property name consistency (organization→organisation for schema compliance)
- Updated test data and fixtures to use new table names
- Fixed schema validation errors caused by property name mismatches
- All database tests now passing

Key tables renamed:
- buerger → citizen
- standort → scope
- oeffnungszeit → availability
- gesamtkalender → overall_calendar
- organisation → organization
- And 28+ other tables

This addresses technical debt by:
- Standardizing all database table names to English snake_case
- Ensuring consistent naming conventions across the codebase
- Making the codebase more accessible to new developers
- Reducing debugging complexity and refactoring costs

Next phases will address column names and PHP variable mappings.
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 6, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)
  • next

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore-GH-1427-standardize-database-field-and-table-naming-conventions

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ThomasAFink ThomasAFink added code complexity and formatting Reduce code complexity or fix formatting refactor to refarch Everything related for future modules projects which refactor to it@m refarch refactor Every day refactor labels Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code complexity and formatting Reduce code complexity or fix formatting refactor to refarch Everything related for future modules projects which refactor to it@m refarch refactor Every day refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants