[10.0] fixed error when we're launch new instance (clients) #411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yelizariev
suggested changes
Nov 29, 2016
Contributor
yelizariev
left a comment
yelizariev
left a comment
There was a problem hiding this comment.
Seems that template creation doesn't work
saas_server/models/saas_server.py
Outdated
| if len(parent_paths) > 1: | ||
| parent_path = parent_paths[0] | ||
| new_db_filstore_path = parent_path + new_db | ||
| copy_tree(path_file_store, new_db_filstore_path) |
Contributor
There was a problem hiding this comment.
There is an error on runbot. Have you tried to create template with new code? I guess you need to move this block below in else block, i.e. copy filestore only for non-template db
Author
|
i think the first when we're create template have not filestore and will show error, i try catch for passing the first create database |
Contributor
|
It's better to avoid using try block whenever it's possible. So, could you move the code under |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed error web browse can not login, and after login, browse is blank (because saas_client/../saas_client.js use openerp.function (params old version)
fixed bug when we're create new instance , the same copy filestore