Fix #806 - Create "A" instead of "CNAME" record for Client in route53 #807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sue #806) Creating an A record for the client avoids error when creating mailgun verification MX record for client database. Before applying this fix, existing CNAME records of clients, should be changed to A records, with the IP of their respective servers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves issue #806 for mailgun and route53 users
Creating an A record instead of a CNAME record for the client, in route53, avoids error when automatically creating mailgun verification MX record for client database.
The problem with this fix, is that before applying it, existing CNAME records of clients, should be
changed to A records, with the IP address of their respective servers. Because of this, I am not sure if this fix should be merged.
Congratulations for your great work.