[Bugfix] #8250 undefined service name

[yuliiakaras]

#8250

Summary by CodeRabbit

• Style

  • Updated bag name fields in the order details to display language-specific names more clearly as Ukrainian and English.

• Tests

  • Adjusted test data to use updated property names for bag names, reflecting explicit language keys.

• Chores

  • Renamed internal data properties for bag names to improve clarity and consistency across the application.

[coderabbitai]

Walkthrough

This change standardizes the naming of bag service properties related to language localization in the admin order details feature. Specifically, it replaces the previous name and nameEng property names with nameUk and nameEn across the interface definition, HTML template bindings, test mocks, and mock data. The update clarifies which language each property represents, without altering any application logic, data structure, or control flow.

Changes

File(s)	Change Summary
src/app/ubs/ubs-admin/components/ubs-admin-order-details-form/ubs-admin-order-details-form.component.html	Updated template bindings to use nameUk and nameEn instead of name and nameEng for bag names.
src/app/ubs/ubs-admin/models/ubs-admin.interface.ts	Renamed IBags interface properties: name → nameUk, nameEng → nameEn.
src/app/ubs/ubs-admin/services/order.service.spec.ts	Updated test mock data to use nameUk and nameEn instead of name and nameEng.
src/app/ubs/ubs-admin/services/orderInfoMock.ts	Changed mock data keys from name/nameEng to nameUk/nameEn for bag items.

Sequence Diagram(s)

sequenceDiagram
    participant Admin as Admin UI
    participant OrderDetails as Order Details Component
    participant DataModel as IBags Interface/Data
    Admin->>OrderDetails: Request order details
    OrderDetails->>DataModel: Access bag names via nameUk/nameEn
    OrderDetails-->>Admin: Display bag names in selected language

Loading

Possibly related PRs

• [Bugfix] #8250 fix undefined payment and order statuses #3633: Renames language-specific properties in the same interface and updates template bindings to match new naming conventions.
• [Refactor] #8261 fix naming #3613: Refactors property names for localization consistency, similar to the changes in this PR.

Suggested reviewers

• Tadei-Mykola
• holus-bolus
• hnativlyubomyr

Poem

🐇
A hop, a skip, a tidy tweak,
Bag names now clear in every speak.
From name and nameEng we now ascend,
To nameUk and nameEn—let clarity extend!
With every language neat and bright,
The order form now shows it right.
Hooray for code that’s crystal clear—
A rabbit’s cheer for all to hear!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 04f39a2 and 488880d.

📒 Files selected for processing (4)

• src/app/ubs/ubs-admin/components/ubs-admin-order-details-form/ubs-admin-order-details-form.component.html (1 hunks)
• src/app/ubs/ubs-admin/models/ubs-admin.interface.ts (1 hunks)
• src/app/ubs/ubs-admin/services/order.service.spec.ts (1 hunks)
• src/app/ubs/ubs-admin/services/orderInfoMock.ts (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: build (18.x)

🔇 Additional comments (4)

src/app/ubs/ubs-admin/models/ubs-admin.interface.ts (1)

174-175: Property naming standardization looks good.

The renaming of properties from name and nameEng to nameUk and nameEn in the IBags interface improves consistency with other interfaces in the codebase that follow the same language indicator pattern (like EmployeePositions, TariffItem, etc.).

src/app/ubs/ubs-admin/components/ubs-admin-order-details-form/ubs-admin-order-details-form.component.html (1)

23-23: Property reference update correctly implemented.

The template binding has been properly updated to use the renamed bag properties, maintaining consistency with the interface changes.

src/app/ubs/ubs-admin/services/order.service.spec.ts (1)

92-93: Test data aligned with interface changes.

The mock data for unit tests has been updated to match the new property names in the IBags interface, ensuring tests will pass with the updated model.

src/app/ubs/ubs-admin/services/orderInfoMock.ts (1)

118-119: Mock data properly aligned with interface changes.

The mock data has been correctly updated to use the renamed properties nameUk and nameEn, maintaining consistency with the IBags interface changes.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud