-
Notifications
You must be signed in to change notification settings - Fork 47
Bugfix/added technical support block to main page and fixed styles #3932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughAdded a tech_support time-frame block to the UBS main page template, updated responsive styling across main and price sections, and added English and Ukrainian translation keys for tech support. Styling refactors simplified legacy price-section rules and adjusted layout, spacing, and typography. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/app/ubs/ubs/components/ubs-main-page/ubs-price-section/ubs-price-section.component.scss (1)
138-142: Consider reducing!importantusage.Multiple
!importantdeclarations appear across the responsive blocks (lines 141, 272, 305, 342). While this may be necessary for overriding inherited styles in nested media queries, consider refactoring the specificity hierarchy to avoid relying on!importantif this file grows further.
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
src/app/ubs/ubs/components/ubs-main-page/ubs-main-page.component.htmlsrc/app/ubs/ubs/components/ubs-main-page/ubs-main-page.component.scsssrc/app/ubs/ubs/components/ubs-main-page/ubs-price-section/ubs-price-section.component.scsssrc/assets/i18n/ubs-admin/en.jsonsrc/assets/i18n/ubs-admin/uk.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build (18.x)
🔇 Additional comments (10)
src/assets/i18n/ubs-admin/en.json (1)
1378-1382: LGTM!The new i18n keys for technical support (
tech_support,tech_support_caption) follow the existing naming conventions and structure within thehow_workssection, consistent with theworking_hoursandroutepatterns.src/assets/i18n/ubs-admin/uk.json (1)
1377-1381: LGTM!Ukrainian translations for the technical support section are properly provided and follow the same structure as the English translations.
src/app/ubs/ubs/components/ubs-main-page/ubs-main-page.component.html (1)
125-128: LGTM!The new technical support time-frame block follows the established pattern of sibling blocks (working hours, route) and properly uses optional chaining for safe property access. The structure is consistent with the existing implementation.
src/app/ubs/ubs/components/ubs-main-page/ubs-price-section/ubs-price-section.component.scss (2)
9-17: LGTM!Base styles are properly defined with margin reset and consistent padding. The h2 typography is well-structured.
155-236: LGTM!The responsive styling structure with nested media query mixins provides granular control across breakpoints. The mobile-first approach with targeted desktop overrides is well-organized.
src/app/ubs/ubs/components/ubs-main-page/ubs-main-page.component.scss (5)
13-13: LGTM!Adding
sans-serifas a fallback font is a good practice for resilience when the custom font fails to load.
583-584: LGTM!The
gap: 10pxaddition properly spaces the time-frame blocks in#main-content, accommodating the new technical support block.
1098-1098: LGTM!Switching to
flex-direction: columnat this breakpoint appropriately stacks the three time-frame blocks vertically when horizontal space is limited.
1374-1375: LGTM!The column layout with centered alignment properly handles the time-frame blocks at medium viewport sizes.
1582-1583: LGTM!Consistent column layout and centering at smaller breakpoints ensures proper display of all time-frame blocks.
95a7cd9 to
8637ee8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/app/ubs/ubs/components/ubs-main-page/ubs-price-section/ubs-price-section.component.scss (1)
141-141: Consider reducing!importantusage.Multiple
line-height: 20px !importantdeclarations suggest potential specificity conflicts. While this works, it may make future style overrides more difficult.♻️ Suggested approach
Consider increasing selector specificity instead of using
!important, or consolidating these rules to reduce duplication. For example:- line-height: 20px !important; + line-height: 20px;If the parent styles are causing conflicts, address the specificity at the source rather than forcing overrides.
Also applies to: 272-272, 305-305, 342-342
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
src/app/ubs/ubs/components/ubs-main-page/ubs-main-page.component.htmlsrc/app/ubs/ubs/components/ubs-main-page/ubs-main-page.component.scsssrc/app/ubs/ubs/components/ubs-main-page/ubs-price-section/ubs-price-section.component.scsssrc/assets/i18n/ubs-admin/en.jsonsrc/assets/i18n/ubs-admin/uk.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build (18.x)
🔇 Additional comments (9)
src/app/ubs/ubs/components/ubs-main-page/ubs-main-page.component.scss (3)
13-13: Good addition of font fallback.Adding
sans-serifas a fallback ensures text remains readable if the CSS variable or custom font fails to load.
583-583: LGTM: Gap addition for time-frame blocks.The
gap: 10pxprovides consistent spacing between the time-frame blocks in the#main-contentcontainer, which now accommodates three blocks including the new tech_support section.
1098-1098: Vertical layout adjustments for responsive breakpoints.The
flex-direction: columnandalign-items: centerchanges appropriately stack the time-frame blocks vertically on smaller screens, ensuring the three blocks (working hours, tech support, route) display properly across all breakpoints.Also applies to: 1374-1375, 1582-1583
src/app/ubs/ubs/components/ubs-main-page/ubs-price-section/ubs-price-section.component.scss (2)
9-17: Base styling updates look appropriate.The margin, padding, and h2 typography changes establish a consistent base for the price section component.
155-358: Comprehensive responsive styling implementation.The responsive styling covers all major breakpoints (sm, md, xl, 3xl) with appropriate adjustments for price card sizing, typography, and layout. The mobile-first approach with PC-first nested blocks follows the project's existing pattern.
src/assets/i18n/ubs-admin/en.json (1)
1378-1382: Translation keys properly added.The new
tech_supportandtech_support_captionkeys follow the existing naming convention and are correctly placed within thehow_workssection. The structure mirrors the existingworking_hoursandroutepatterns.src/assets/i18n/ubs-admin/uk.json (1)
1377-1381: Ukrainian translations properly added.The Ukrainian translation keys mirror the English file structure, and the translations appear linguistically appropriate. The consistency between
en.jsonanduk.jsonensures proper i18n support for the new tech support block.src/app/ubs/ubs/components/ubs-main-page/ubs-main-page.component.html (2)
125-128: New tech support time-frame block correctly implemented.The structure follows the existing pattern for
working_hoursandrouteblocks. The optional chaining (?.) provides appropriate null safety.
122-127: Angular's[innerHTML]binding automatically sanitizes content by default—no additional explicit sanitization is required.The template uses
[innerHTML]to bind admin-controlled content, but Angular automatically sanitizes HTML bindings in templates using its built-in DomSanitizer. This prevents XSS attacks without requiring explicitsanitize()calls in the component. Unless the content is processed throughbypassSecurityTrustHtml()(which it is not here), this binding is secure.Likely an incorrect or invalid review comment.
|
* changed view encapsulation from none to emulated in main page comp to fix styles leakage * Bugfix/table cell date and address fix (#3930) * Bugfix/table col width fix, changed pwa app name (#3929) * changed pwa app name * admin table row styles * Bugfix #8972 profile deactivation (#3925) * Fix #8972 changed profile deactivation base url, changed a request body format * Fix #8972 changed profile deactivation base url, changed a request body format * Bugfix/added technical support block to main page and fixed styles (#3932) * added technical support block for main page * fixed translation for new tech support quills, fixed styles for main page * tests fix * Fix/frontend bugs (#3931) * Add snack-bar instead 'offline' field in header * Add filter tags for Customers * Fix sorting in customers orders table * Remove coma * Add tests for snack bar and filter tags * Fix coderabbit issues * Fix coderabbit issues * Remove commas --------- Co-authored-by: vryazh <vryazhskaya@gmail.com> Co-authored-by: Saienko Volodymyr <48810972+SaenkoVova@users.noreply.github.com> Co-authored-by: AnastasiaRakuta <168209962+AnastasiaRakuta@users.noreply.github.com>



Added techinacal support block next to working hours, fixed styles and responsiveness
Added translation to quill editors of technical support block and caption
Summary by CodeRabbit
New Features
Style
Localization
Tests
✏️ Tip: You can customize this high-level summary in your review settings.