fix: dimmer AT firefox/macos quirks#438
Merged
Merged
Conversation
…iceOver first-load reachability On Mac/Firefox/VoiceOver, background card headings were reachable via AT navigation on first page load when `active` was set declaratively. After toggling off then on, the bug disappeared — confirming a timing issue. Root cause: `_updateBackgroundInert()` applied `inert` during `slotchange`, but child custom elements (it-card) were still upgrading their shadow DOM at that point. Firefox's AT registered the heading links before the `inert` constraint propagated through the fully-rendered tree. Fix: override `firstUpdated()` to re-apply `_updateBackgroundInert()` after one rAF, matching the AT-settlement pattern in focus-trap-controller. Also documents BSI#1165 (upstream bootstrap-italia a11y issue) in dimmer.scss since it cannot be addressed from this layer. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…iceOver The rAF firstUpdated workaround did not fix the issue. Root cause: Firefox's inert implementation does not propagate through shadow DOM slot boundaries when building its accessibility tree on first page load. inert IS set in the DOM but Firefox VoiceOver still finds slotted <a> links inside custom elements (e.g. it-card) because it does not walk the light DOM ancestor chain when creating AT nodes for shadow DOM content. aria-hidden="true" operates on the DOM tree (not the flat tree) and Firefox has mature, correct support for it: when set on a container, it explicitly excludes the element and all DOM-tree descendants from the accessibility tree, including light DOM children that happen to be slotted into child custom elements. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: d7f39d3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 45 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
giuliaghisini
approved these changes
Jun 16, 2026
Contributor
|
@deodorhunter manca solo il changeset |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #60 (comment): firefox/macos specific quirks in AT rendering on page load, add aria-hidden attributes alongside inert