3.4#284
Merged
Merged
Conversation
wallet-provider: fix config
wallet-provider: update config
update wallet instance script
- added pid credential - /par path fixed
- migrate wallet_provider entity to wallet_solution pyeudiw: - added default_target_backend directive
…-cli. Fix Run-docker-compose for environment and update script for pagopa cli. Major fix and update for configuration\script pagopa-cli
- Port into service - Disable, ONLY FOR TESTING, the SSL verification
wallet demo compose
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 29153369 | Triggered | Generic Password | 7deb4ba | Docker-compose/run-docker-compose.sh | View secret |
| 29153370 | Triggered | Username Password | 7deb4ba | Docker-compose/run-docker-compose.sh | View secret |
| 29153370 | Triggered | Username Password | a2d8b7d | Docker-compose/run-docker-compose.sh | View secret |
| 29153369 | Triggered | Generic Password | 2311aa0 | Docker-compose/run-docker-compose.sh | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
# Conflicts: # Docker-compose/docker-compose.yml
fixes: cie-oidc config; internal_attributes.yaml
cleanup and fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several important updates to the Docker Compose setup, CI workflows, and environment configuration to support new demo services, improve static preview deployment, and enhance configuration for the CIE OIDC backend. The changes include adding new demo containers, updating service images and health checks, refining environment variable management, and introducing new GitHub Actions workflows for static previews.
Docker Compose and Demo Services:
wallet-instance-demoandpagopa-wallet-cli, each with their own build contexts, ports, and environment variables.iam-proxy-italia,trust-anchor, andcie-providerservices to use specific image versions, improved health checks, and more explicit environment variables for trust anchor and provider URLs. [1] [2] [3]CI/CD and Static Preview Workflows:
.github/workflows/static-preview-deploy.ymlto deploy static previews for each branch to GitHub Pages when static files change, including linting and per-branch subfolder deployment..github/workflows/static-preview-cleanup.ymlto automatically remove static preview subfolders from GitHub Pages when branches are deleted..github/workflows/cie-oidc-backend.ymlto trigger only on backend-relevant files, improving CI efficiency.Environment Configuration:
Docker-compose/env.exampleto include example variables for trust anchor and provider URLs, and the new MongoDB trust chain collection. [1] [2]pagopa-wallet-clidemo.Codebase Cleanup:
Miscellaneous:
.lycheecachewith new URLs, reflecting recent documentation and resource changes.These changes collectively improve the maintainability, clarity, and demo capabilities of the project, while also making CI/CD workflows more robust and tailored to the project's structure.