Skip to content

fix/wrong contact fields after import#402

Merged
valeriocomo merged 1 commit intodevelopfrom
fix/wrong-contact-fields-after-import
May 7, 2025
Merged

fix/wrong contact fields after import#402
valeriocomo merged 1 commit intodevelopfrom
fix/wrong-contact-fields-after-import

Conversation

@AlexPalaz
Copy link
Copy Markdown
Collaborator

✅ What’s been done

EditorContacts component has been updated to correctly re-render its input fields when a new YAML file is imported. This was achieved by adding a key prop that changes whenever the YAML content changes, ensuring stale data from previous imports is not shown.


✨ Features

Re-render EditorContacts on YAML file change by setting a dynamic key.


💥 Breaking changes

No breaking changes introduced.

@AlexPalaz AlexPalaz requested a review from valeriocomo May 7, 2025 10:02
@vercel
Copy link
Copy Markdown

vercel Bot commented May 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
publiccode-editor ✅ Ready (Inspect) Visit Preview May 7, 2025 10:02am
publiccode-editor-legacy ✅ Ready (Inspect) Visit Preview May 7, 2025 10:02am

@AlexPalaz AlexPalaz changed the base branch from main to develop May 7, 2025 10:03
Copy link
Copy Markdown
Member

@valeriocomo valeriocomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@valeriocomo valeriocomo merged commit b07cdfe into develop May 7, 2025
9 checks passed
@valeriocomo valeriocomo deleted the fix/wrong-contact-fields-after-import branch May 7, 2025 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants