feat(metrics): v1.90 contract freeze — alias removal + governance#432
Merged
feat(metrics): v1.90 contract freeze — alias removal + governance#432
Conversation
…esign principles Track A.1: Remove 9 deprecated metric aliases (INV-M-007 completed) - nftban_go_goroutines → removed (use nftban_runtime_goroutines) - nftban_go_gc_cpu_fraction → removed (use nftban_runtime_gc_cpu_fraction) - nftban_go_gc_pause_seconds → removed (use nftban_runtime_gc_pause_seconds) - nftban_go_heap_alloc_bytes → removed (use nftban_runtime_heap_alloc_bytes) - nftban_go_heap_inuse_bytes → removed (use nftban_runtime_heap_inuse_bytes) - nftban_go_heap_released_bytes → removed (use nftban_runtime_heap_released_bytes) - nftban_softnet_drops_total → removed (use nftban_softnet_drops) - nftban_softnet_time_squeeze_total → removed (use nftban_softnet_time_squeeze) - nftban_nic_rx_dropped_total → removed (use nftban_nic_rx_dropped) Canonical metric count: 110 (frozen) Governance files: - STATUS.md: Integrity & Build Status audit surface (24 workflows, 9 gates) - CODE_OF_CONDUCT.md: Engineering-aligned conduct policy - docs/DESIGN_PRINCIPLES.md: 12 design principles for 1.9x line - SECURITY.md: Added STATUS.md link for auditor flow - CONTRIBUTING.md: Added system integrity model section Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
G90 blocker fix — exporter metric naming alignment. Shell unified exporter was emitting 'nftban_softnet_drops_total' while daemon /metrics emits 'nftban_softnet_drops' (canonical v1.90 name). Fixed: - nftban_unified_exporter_collect.sh: nftban_softnet_drops_total → nftban_softnet_drops - nftban_unified_exporter_collect.sh: JSON key softnet_drops_total → softnet_drops - nftban_exporter_json_compat.sh: softnet_drops_total → softnet_drops All export surfaces now agree on canonical metric name. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
….F-7)
Cross-surface audit found 7 proven phantom/wrong metric names in
dashboards and alerts. All fixed:
F-1: nftban_fail2ban_jails_active → removed (phantom, fail2ban not used)
F-2: nftban_health_status{component="fail2ban"} → replaced with daemon
F-3: nftban_nftables_rules_count → nftban_nftables_rules_total
F-4: nftban_last_update_timestamp → nftban_exporter_last_success_timestamp
F-5: nftban_blocks_permanent/temporary → nftban_blacklist_ipv4_perm/temp
F-6: nftban_blocks_by_country → nftban_bans_by_country_total
F-7: Stale fail2ban text → removed (all fail2ban references purged)
All 5 files updated:
- install/prometheus/alerts/nftban-metrics.yml
- install/grafana/dashboards/nftban_performance.json
- install/grafana/dashboards/nftban_overview.json
- install/grafana/dashboards/nftban_health.json
- install/grafana/dashboards/nftban_geographic.json
Zero phantom metric names remaining in any dashboard/alert/template.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
CI Policy Gates require generated FHS outputs to match the canonical spec. VERSION bump to 1.90.0 caused header version drift. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v1.90 Contract Freeze
Track A.1: Remove 9 deprecated metric aliases
INV-M-007 completed. The one-release compatibility window (v1.89) has passed.
Removed aliases:
nftban_go_goroutinesnftban_runtime_goroutinesnftban_go_gc_cpu_fractionnftban_runtime_gc_cpu_fractionnftban_go_gc_pause_secondsnftban_runtime_gc_pause_secondsnftban_go_heap_alloc_bytesnftban_runtime_heap_alloc_bytesnftban_go_heap_inuse_bytesnftban_runtime_heap_inuse_bytesnftban_go_heap_released_bytesnftban_runtime_heap_released_bytesnftban_softnet_drops_totalnftban_softnet_dropsnftban_softnet_time_squeeze_totalnftban_softnet_time_squeezenftban_nic_rx_dropped_totalnftban_nic_rx_droppedCanonical metric count: 110 (frozen)
Governance files
STATUS.md— Integrity & Build Status audit surface (24 workflows, 9 contract gates)CODE_OF_CONDUCT.md— Engineering-aligned conduct policydocs/DESIGN_PRINCIPLES.md— 12 design principles for 1.9x lineSECURITY.md— Added STATUS.md link for auditor flowCONTRIBUTING.md— Added system integrity model sectionInvariants verified
All 8 invariants (INV-M-001 through INV-M-008) still hold after alias removal.
🤖 Generated with Claude Code