feat(exporter): align shell/collector metrics to daemon canonical names#435
Closed
feat(exporter): align shell/collector metrics to daemon canonical names#435
Conversation
Unify metric names across all export surfaces to match the daemon
/metrics contract frozen in v1.90.0. The shell exporter is a relay
of daemon vocabulary, not a parallel namespace.
Renames (shell/collector → daemon canonical):
- P-1: nftban_goroutines → nftban_runtime_goroutines
- P-1b: nftban_daemon_goroutines → nftban_runtime_goroutines
- P-2: nftban_conntrack_entries → nftban_conntrack_used
- P-3: nftban_memory_rss_bytes → nftban_proc_rss_bytes
- P-4: nftban_watchdog_{cpu,mem,io,net}_score → nftban_pressure_score{dim=X}
- P-5: nftban_watchdog_mode (integer) → nftban_operating_mode{mode=X} (one-hot)
- P-6: nftban_nftables_rules_total → nftban_nft_rules_total
Updated across: shell exporter, Go collector, dashboards, alerts,
metrics-registry.json, and HELP/TYPE headers.
Pipeline audit: V191_PIPELINE_INTEGRITY_AUDIT.md (P-1 through P-7)
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
4 tasks
Owner
Author
|
Superseded by #437 (combined v1.91 PR) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renames
nftban_goroutinesnftban_runtime_goroutinesnftban_daemon_goroutinesnftban_runtime_goroutinesnftban_conntrack_entriesnftban_conntrack_usednftban_memory_rss_bytesnftban_proc_rss_bytesnftban_watchdog_{cpu,mem,io,net}_scorenftban_pressure_score{dim=X}nftban_watchdog_mode(integer)nftban_operating_mode{mode=X}(one-hot)nftban_nftables_rules_totalnftban_nft_rules_totalFiles changed
nftban_unified_exporter_collect.sh— all metric renamesnftban_unified_exporter_export.sh— HELP/TYPE header updateinternal/metrics/collector.go— Go textfile collector P-6 renamenftban_performance.json— dashboard query updatenftban-metrics.yml— alert expression updatemetrics-registry.json— registry entries + Zabbix mappingsTest plan
grep -R "nftban_nftables_rules_total" .→ 0 active emittersgrep -R "nftban_watchdog_cpu_score" cli/lib/→ 0 active emittersgrep -R "nftban_goroutines\b" cli/lib/→ 0 (only nftban_runtime_goroutines)Ref: V191_PIPELINE_INTEGRITY_AUDIT.md (P-1 through P-7)
🤖 Generated with Claude Code