feat(cleanup): decommission fail2ban as active data source#436
Closed
feat(cleanup): decommission fail2ban as active data source#436
Conversation
Remove fail2ban as an ingestion/analytics dimension. No active code path produces fail2ban data — all references were either dead struct fields, dead parser constants, or phantom label values. Removed: - analytics/types.go: Jail field + ByJail map (zero writers) - analytics/state.go: legacy jail comment - banlog/banlog.go: SourceFail2ban constant + case "fail2ban" parser - handlers_analytics.go: case "fail2ban" display mapping - metrics-registry.json: "fail2ban" from health_status label values Kept (conflict detection — required for safe install): - nftban_firewall_conflicts.sh (~50 refs) - nftban_checks.sh, cmd_firewall.sh, cmd_health_analysis.sh - nftbanconf/services.go Fail2banService field Historical bans.log entries with source=fail2ban are preserved as raw strings — they pass through the default case in NormalizeSource(). Ref: V191_FAIL2BAN_DECOMMISSION_PLAN.md Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
The struct literal at state.go:229 still referenced the removed Jail field, causing go vet to fail. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
cmd_analytics.go also printed the removed Jail field in IP lookup output. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
4 tasks
Owner
Author
|
Superseded by #437 (combined v1.91 PR) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removed
analytics/types.goJailfield +ByJailmapanalytics/state.gobanlog/banlog.goSourceFail2banconstant +case "fail2ban"handlers_analytics.gocase "fail2ban"display mappingmetrics-registry.json"fail2ban"from health_status labelsKept (conflict detection)
nftban_firewall_conflicts.sh(~50 refs)nftban_checks.sh,cmd_firewall.sh,cmd_health_analysis.shnftbanconf/services.goFail2banServicefieldTest plan
grep -rn 'SourceFail2ban' internal/→ 0 matchesgrep -rn '\.Jail\b' internal/analytics/→ 0 matchesgrep -rn 'ByJail' internal/analytics/→ 0 matchesgrep -c 'fail2ban' cli/lib/nftban/core/nftban_firewall_conflicts.sh→ still ~50Ref: V191_FAIL2BAN_DECOMMISSION_PLAN.md
🤖 Generated with Claude Code