feat(smoke): v1.94 — registry-driven CLI smoke framework#449
Merged
Conversation
Phase 1: minimal, contract-safe smoke command. New package: internal/smoke/ - registry.go: Canonical test registry with SmokeTest struct (ID, Command, AllowedExit, Prerequisites, FatalPatterns, Assert) - smoke.go: Runner with prerequisite checking, fatal error detection, PASS/FAIL/SKIP semantics, timeout enforcement - report.go: Human + JSON formatters, exit code mapping Phase 1 test set (6 probes): - T1: validator JSON (truth, validator-backed) - T2: health JSON (truth, validator-backed) - T3: status (truth, no crash) - D1: nftband.service active (daemon) - C1: main.conf readable (config) - M1: /metrics reachable (metrics) CLI: nftban smoke [--json] [--group=truth|daemon|config|metrics|all] Exit: 0=PASS, 1=FAIL, 2=INTERNAL ERROR. SKIP does not cause failure. Fatal runtime detection: panic, segfault, unbound variable, syntax error, bad array subscript, command not found — always FAIL. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Registry-driven smoke core. Lab4 PASS. Recreated from #445/#447 to clear code scanning comments.
🤖 Generated with Claude Code