Conversation
…cked files
Mechanical dev-machine path cleanup. Closes repo hygiene audit
findings H-01, H-02, and H-03: hardcoded /home/gituser/...
defaults that leaked the maintainer's filesystem layout and broke
non-author runs.
Changes:
- scripts/export_cli_inventory.sh (H-01): repo-relative dev fallback
via readlink -f "$0" + ../cli/lib/nftban/cli
- scripts/validate_cli_help.sh (H-01): same pattern
- cli/lib/nftban/tests/selftest.sh (H-01): same pattern using
BASH_SOURCE[0]
- cli/lib/nftban/core/nftban_health_checks_config.sh (H-02): drop
/home/gituser/github/nftban-dev from auto-heal search list; use
/usr/share/nftban/src (canonical install-time source) +
${NFTBAN_DEV_SRC_DIR:-} opt-in for maintainers
- cli/lib/nftban/core/nftban_health_checks_services.sh (H-02): same
pattern for timer auto-install path
- tools/expand-config-schema.sh (H-03): INPUT_SKELETON required via
:? (no public default for internal skeleton); OUTPUT_SCHEMA
resolved repo-relative from the script's own location
Verification gate (locked):
git grep -nE "/home/gituser|/home/commonfolder|nftban-v1.0-dev" \
-- ":(exclude).claude/*"
Remaining 4 hits are intentionally deferred outside this slice:
- 3 × H-04 sites (locked to slice 1c)
- 1 × scripts/test_server_cleanup.sh:121 (one-shot dev cleanup
script, not in audit H-list)
Out of scope (deferred): H-04 / H-05 / H-07 / H-08 / H-09 / H-16 /
H-19 — separate Phase A slices.
Lifecycle completion lane (PR-25..PR-30) remains explicitly OPEN.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Repo hygiene Phase A — slice 1b. Mechanical dev-machine path cleanup across 6 files.
Closes audit findings H-01, H-02, H-03: hardcoded `/home/gituser/github/...nftban-v1.0-dev` and `/home/gituser/github/nftban-dev` defaults that leaked the maintainer's filesystem layout and broke non-author runs.
Files (locked scope — exactly 6)
7 files changed, 69 insertions(+), 13 deletions(-) — most of the diff is the CHANGELOG entry.
Locked verification gate
```bash
git grep -nE "/home/gituser|/home/commonfolder|nftban-v1.0-dev" -- ':(exclude).claude/*'
```
After this PR, the gate produces only intentionally-deferred hits:
This matches the user's locked acceptance: "empty, or only hits that are intentionally deferred and explicitly excluded from this slice if any remain outside the targeted files."
Out of scope (deferred)
Lifecycle completion lane (PR-25..PR-30) remains explicitly OPEN.
Test plan
🤖 Generated with Claude Code