Skip to content

One form #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 2, 2025
Merged

One form #505

merged 2 commits into from
May 2, 2025

Conversation

overmannen
Copy link
Contributor

Before:
Skjermbilde 2025-04-26 kl  16 43 07
After:
Skjermbilde 2025-04-26 kl  16 42 48

Unified three separate forms to ensure consistent option saving. Addresses an issue where options from one form were not saved if another form's save button was clicked.

Copy link
Contributor

@christiangryt christiangryt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I do wonder why this wasn't the case before.

I am unsure about the amount of files changed, but if this is intentional, the result works for me.

@overmannen overmannen merged commit 4a58186 into master May 2, 2025
3 checks passed
@overmannen overmannen deleted the one_form branch May 2, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants