fix: restore rdmaRegister guard and guard heapRkeys_ memcpy in proxy path - #18
Merged
Merged
Conversation
…path 1. Restore rdmaRegister check in proxy path (line 198) — without it, SDMA-only buffers that shouldn't be registered hit ibv_reg_mr, which can fail on ionic's single-MR limit. 2. Guard heapRkeys_ memcpy against empty vector — in ShmemMode::Isolation the heap is never registered so heapRkeys_ is empty, causing memcpy from nullptr. Addresses PR ROCm#558 review comments #5 and #6. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses PR ROCm#558 review comments #5 and #6.
rdmaRegistercheck in proxy path — without it, SDMA-only buffers hitibv_reg_mrwhich can fail on ionic's single-MR limit.heapRkeys_memcpy against empty vector — inShmemMode::Isolationthe heap is never registered, soheapRkeys_is empty and.data()returns nullptr.Test plan
🤖 Generated with Claude Code