fix: replace x86 asm with portable std::atomic_thread_fence - #21
Merged
Merged
Conversation
clflush/sfence are x86-only and break aarch64 builds. The file is compiled unconditionally. clflush is also a no-op on uncached device memory (hipDeviceMallocUncached). Replace with portable std::atomic_thread_fence(std::memory_order_seq_cst). Addresses PR ROCm#558 round-2 review comment R2-4. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses PR ROCm#558 round-2 review comment R2-4 (blocking).
clflush/sfenceare x86-only inline asm and break aarch64 builds. The fileproxy_thread.cppis compiled unconditionally. Additionally,clflushis a no-op on uncached device memory (hipDeviceMallocUncached).Replace with portable
std::atomic_thread_fence(std::memory_order_seq_cst).Test plan
🤖 Generated with Claude Code