Add missing raise_for_status() error handling on AS4 submission#18
Merged
arj03 merged 2 commits intoiterasdev:masterfrom Feb 27, 2026
Merged
Add missing raise_for_status() error handling on AS4 submission#18arj03 merged 2 commits intoiterasdev:masterfrom
arj03 merged 2 commits intoiterasdev:masterfrom
Conversation
Collaborator
|
Hmm, that doesn't look correct. The logic is a bit tricky here, but it appears that if you get not 200, then futher down it tries to make a proper error out of it. With this raise it will bubble up the HTTPError and not give you a sendpeppol error? |
Collaborator
Author
|
Hm, you're right, it breaks logic down below, I didn't look far enough. The problem I was running into was a Peppol AP that returned an error 500 with no body, therefore breaking the etree.fromstring() line in a way that said "empty body", which feld less helpful in logs than "error 500" |
Collaborator
Author
|
New attempt pushed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.