Include context path in S3 presigned URLs #17832
Merged
+43
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17831
Summary
/storage/v1/s3for Supabase) in presigned URLsgetVirtualPath()in the anonymousRestS3Serviceinstance used for URL signingRequestEntityRestStorageServicefor regular S3 requestsProblem
When using Cyberduck with the official Supabase Storage S3 profile (which sets
Context=/storage/v1/s3), "Copy URL → Signed URL" generates a presigned URL that omits the context path prefix. The generated URL points tohttps://<host>/<bucket>/<key>instead ofhttps://<host>/storage/v1/s3/<bucket>/<key>, causing Supabase to return{"error":"requested path is invalid"}.Solution
The fix adds a
getVirtualPath()override inS3PresignedUrlProviderthat returns the context path from the protocol configuration. This ensures the context path is included in both:Backward Compatibility
This change is backward compatible:
getContext()returns empty/null,getVirtualPath()returns an empty string — behavior unchangedContextsetting (like Supabase) are affectedTest plan
testContextPath()verifying presigned URLs include the context path when configured