Send NOOP on control socket during file transfers.#18096
Draft
dkocher wants to merge 4 commits into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Implements FTP control-connection keepalive during streaming uploads/downloads (to address #9075) by sending periodic NOOP commands while reading from / writing to data connections.
Changes:
- Add periodic
sendNoOp()calls duringFTPReadFeaturedownloads based on the configured control keepalive interval. - Add periodic
sendNoOp()calls duringFTPWriteFeatureuploads based on the configured control keepalive interval. - Refactor stream wrapper constructors to accept an idle/keepalive
Duration.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| ftp/src/main/java/ch/cyberduck/core/ftp/FTPWriteFeature.java | Sends periodic NOOP on control connection during upload stream writes. |
| ftp/src/main/java/ch/cyberduck/core/ftp/FTPReadFeature.java | Sends periodic NOOP on control connection during download stream reads. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #9075.