Add tests#18153
Merged
Merged
Conversation
899dbcb to
6120477
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds/updates integration tests around versioned-object “delete marker” (S3) / “hide marker” (Backblaze B2) behavior, and adjusts B2 attribute mapping to better represent marker states.
Changes:
- Added new S3 and B2 integration tests validating read/find behavior with delete/hide markers and explicit version IDs.
- Enabled S3 versioning listing in the shared S3 test session setup to exercise version-aware listing paths.
- Updated
B2AttributesFinderFeaturemapping for hide markers (trashed) and size handling.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| s3/src/test/java/ch/cyberduck/core/s3/S3ReadFeatureTest.java | Adds a test that reads an explicit version after a delete marker is created and verifies “latest” read fails. |
| s3/src/test/java/ch/cyberduck/core/s3/S3FindFeatureTest.java | Adds a find test covering behavior differences between versioned and non-versioned paths after a delete marker. |
| s3/src/test/java/ch/cyberduck/core/s3/S3AttributesFinderFeatureTest.java | Refactors delete-marker assertions and extends coverage to DefaultAttributesFinderFeature. |
| s3/src/test/java/ch/cyberduck/core/s3/AbstractS3Test.java | Forces s3.listing.versioning.enable=true for the default S3 test session. |
| dracoon/src/test/java/ch/cyberduck/core/sds/SDSFindFeatureTest.java | Ensures the touched file path is reused and asserts find is false after deleting the room. |
| backblaze/src/test/java/ch/cyberduck/core/b2/B2ReadFeatureTest.java | Adds a delete/hide marker read test and modernizes an exception assertion. |
| backblaze/src/test/java/ch/cyberduck/core/b2/B2FindFeatureTest.java | Expands find testing to cover hide markers and validates behavior via both B2 and default find features. |
| backblaze/src/test/java/ch/cyberduck/core/b2/B2AttributesFinderFeatureTest.java | Strengthens hide-marker coverage by validating listing semantics and per-version attribute lookups. |
| backblaze/src/main/java/ch/cyberduck/core/b2/B2AttributesFinderFeature.java | Adjusts attribute mapping: conditional version id assignment for B2FileInfoResponse, and marker/size handling tweaks. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
6120477 to
9d17db7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.