Skip to content

Add tests#18153

Merged
dkocher merged 11 commits into
masterfrom
bugfix/MD-21404-versionid-b2
Jun 2, 2026
Merged

Add tests#18153
dkocher merged 11 commits into
masterfrom
bugfix/MD-21404-versionid-b2

Conversation

@dkocher
Copy link
Copy Markdown
Contributor

@dkocher dkocher commented Jun 2, 2026

No description provided.

@dkocher dkocher added this to the 9.5 milestone Jun 2, 2026
@dkocher dkocher requested a review from a team as a code owner June 2, 2026 08:42
Copilot AI review requested due to automatic review settings June 2, 2026 08:42
@dkocher dkocher added s3 AWS S3 Protocol Implementation b2 Backblaze B2 Protocol Implementation labels Jun 2, 2026
@dkocher dkocher force-pushed the bugfix/MD-21404-versionid-b2 branch from 899dbcb to 6120477 Compare June 2, 2026 08:47
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds/updates integration tests around versioned-object “delete marker” (S3) / “hide marker” (Backblaze B2) behavior, and adjusts B2 attribute mapping to better represent marker states.

Changes:

  • Added new S3 and B2 integration tests validating read/find behavior with delete/hide markers and explicit version IDs.
  • Enabled S3 versioning listing in the shared S3 test session setup to exercise version-aware listing paths.
  • Updated B2AttributesFinderFeature mapping for hide markers (trashed) and size handling.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
s3/src/test/java/ch/cyberduck/core/s3/S3ReadFeatureTest.java Adds a test that reads an explicit version after a delete marker is created and verifies “latest” read fails.
s3/src/test/java/ch/cyberduck/core/s3/S3FindFeatureTest.java Adds a find test covering behavior differences between versioned and non-versioned paths after a delete marker.
s3/src/test/java/ch/cyberduck/core/s3/S3AttributesFinderFeatureTest.java Refactors delete-marker assertions and extends coverage to DefaultAttributesFinderFeature.
s3/src/test/java/ch/cyberduck/core/s3/AbstractS3Test.java Forces s3.listing.versioning.enable=true for the default S3 test session.
dracoon/src/test/java/ch/cyberduck/core/sds/SDSFindFeatureTest.java Ensures the touched file path is reused and asserts find is false after deleting the room.
backblaze/src/test/java/ch/cyberduck/core/b2/B2ReadFeatureTest.java Adds a delete/hide marker read test and modernizes an exception assertion.
backblaze/src/test/java/ch/cyberduck/core/b2/B2FindFeatureTest.java Expands find testing to cover hide markers and validates behavior via both B2 and default find features.
backblaze/src/test/java/ch/cyberduck/core/b2/B2AttributesFinderFeatureTest.java Strengthens hide-marker coverage by validating listing semantics and per-version attribute lookups.
backblaze/src/main/java/ch/cyberduck/core/b2/B2AttributesFinderFeature.java Adjusts attribute mapping: conditional version id assignment for B2FileInfoResponse, and marker/size handling tweaks.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread backblaze/src/main/java/ch/cyberduck/core/b2/B2AttributesFinderFeature.java Outdated
Comment thread backblaze/src/test/java/ch/cyberduck/core/b2/B2FindFeatureTest.java
@dkocher dkocher force-pushed the bugfix/MD-21404-versionid-b2 branch from 6120477 to 9d17db7 Compare June 2, 2026 09:40
@dkocher dkocher merged commit 52b6bde into master Jun 2, 2026
7 checks passed
@dkocher dkocher deleted the bugfix/MD-21404-versionid-b2 branch June 2, 2026 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

b2 Backblaze B2 Protocol Implementation s3 AWS S3 Protocol Implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants