Skip to content

Include vault version in response.#18154

Merged
dkocher merged 3 commits into
masterfrom
bugfix/GH-16642-vaultversion-touch
Jun 3, 2026
Merged

Include vault version in response.#18154
dkocher merged 3 commits into
masterfrom
bugfix/GH-16642-vaultversion-touch

Conversation

@dkocher
Copy link
Copy Markdown
Contributor

@dkocher dkocher commented Jun 2, 2026

No description provided.

@dkocher dkocher added this to the 9.5 milestone Jun 2, 2026
@dkocher dkocher requested a review from ylangisc June 2, 2026 09:45
@dkocher dkocher requested a review from a team as a code owner June 2, 2026 09:45
Copilot AI review requested due to automatic review settings June 2, 2026 09:45
@dkocher dkocher added the cryptomator Cryptomator Vault label Jun 2, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Cryptomator WebDAV integration so that paths returned from encrypted touch (file creation) and encrypted mkdir (directory creation) include the active VaultVersion in their PathAttributes, and adds/updates integration tests to validate this behavior.

Changes:

  • Populate PathAttributes.vaultVersion on decrypted paths returned by CryptoTouchFeature.touch(...).
  • Populate PathAttributes.vaultVersion on decrypted paths returned by CryptoDirectoryFeature.mkdir(...).
  • Extend WebDAV Cryptomator integration tests to assert the vault version is present in the returned attributes.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
cryptomator/src/main/java/ch/cyberduck/core/cryptomator/features/CryptoTouchFeature.java Sets vaultVersion on the decrypted Path returned from touch.
cryptomator/src/main/java/ch/cyberduck/core/cryptomator/features/CryptoDirectoryFeature.java Sets vaultVersion on the decrypted Path returned from mkdir.
webdav/src/test/java/ch/cyberduck/core/cryptomator/DAVTouchFeatureTest.java Adds an integration test intended to validate vault version presence for encrypted touch responses.
webdav/src/test/java/ch/cyberduck/core/cryptomator/DAVDirectoryFeatureTest.java Updates encrypted mkdir test to assert the returned directory includes the vault version.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dkocher dkocher merged commit 92196a4 into master Jun 3, 2026
7 checks passed
@dkocher dkocher deleted the bugfix/GH-16642-vaultversion-touch branch June 3, 2026 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cryptomator Cryptomator Vault

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants