🐛 fix(load-test): use pre-instantiated DI providers#80
Merged
Conversation
The load test runner was still manually instantiating interactor providers, which was missed during the DI refactor in 9c86fb3. Remove the redundant list comprehension and pass `interactor_providers` directly, aligning with the centralized provider setup. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The load test runner was still manually instantiating interactor providers via a list comprehension, which was missed during the DI refactor in 9c86fb3. This fix removes the redundant instantiation and passes
interactor_providersdirectly, aligning with the centralized provider setup used in the bot, API, and tests.Type of Change
Testing
Code Quality
pre-commit run --all-files)ruff check src/ tests/)ruff format src/ tests/ --check)Related Issues
Follow-up fix for #79
Additional Notes
The
interactor_providerslist insrc/infrastructure/di/interactors/__init__.pywas refactored to contain pre-instantiated provider instances. The load test runner was the only consumer that still calledinteractor()on each item, which would fail at runtime since they're already instances, not classes.🤖 Generated with Claude Code