-
Notifications
You must be signed in to change notification settings - Fork 1
Framebuffer #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 4.x
Are you sure you want to change the base?
Framebuffer #1
Changes from 10 commits
7ca8527
fbafa76
462a0e0
30da285
b9efae6
516f2a6
b1cfb7c
d54fad6
78b8be6
49468ff
fb1b36b
e3c702a
9b54898
346a301
e7e0a29
439581b
ee0b70a
7a2f830
9ad906c
ceed483
1fef6a5
8c457ae
e5b3871
b3a1b6d
5339c26
6194366
5b85c52
7b3cadb
2c8d797
a29ebab
1a8e00f
35a6c9c
872594d
b241ef0
d5cce2a
e9d15c8
b9377cd
293872d
c6055b6
6cc910d
a9a8b7a
5164ffc
d5d80bc
4c2d2e6
6706b8a
7d48035
741bbff
66cc5a1
c110050
6aa4d40
c353065
01f95fa
43aa713
81afac4
c0bc02f
9f0dccd
6531b75
db848a7
bbf5874
ba5828d
48f5ec7
dc98bd1
92b3a84
11dff94
ff8b9d9
afdb448
08ba3f2
2e9cbf6
fb01d3b
875f439
9b4f16d
3a61f33
8ece6be
3a63f85
2972dff
dabbb5f
757160b
7b41776
0de5a51
6c5d2dc
2b99518
6bf5fcf
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -39,6 +39,17 @@ if(HAVE_WEBP) | |
add_definitions(-DHAVE_WEBP) | ||
endif() | ||
|
||
|
||
if(WITH_FRAMEBUFFER) | ||
message(WITH_FRAMEBUFFER="${WITH_FRAMEBUFFER}") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It would be better to add separate block to the common configuration output in root CMakeLists.txt, at the end of "GUI" section (https://github.com/opencv/opencv/blob/26a5730f0d36f547a6eaf39b1e15786ea3f0d039/CMakeLists.txt#L1367-L1425). There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The message output has been moved to the root CMakeLists.txt |
||
add_definitions(-DHAVE_FRAMEBUFFER) | ||
list(APPEND highgui_srcs ${CMAKE_CURRENT_LIST_DIR}/src/window_framebuffer.cpp) | ||
list(APPEND highgui_hdrs ${CMAKE_CURRENT_LIST_DIR}/src/window_framebuffer.hpp) | ||
else() | ||
message(WITH_FRAMEBUFFER="${WITH_FRAMEBUFFER}") | ||
endif() | ||
|
||
|
||
file(GLOB highgui_ext_hdrs | ||
"${CMAKE_CURRENT_LIST_DIR}/include/opencv2/*.hpp" | ||
"${CMAKE_CURRENT_LIST_DIR}/include/opencv2/${name}/*.hpp" | ||
|
@@ -180,6 +191,9 @@ elseif(HAVE_COCOA) | |
list(APPEND HIGHGUI_LIBRARIES "-framework Cocoa") | ||
endif() | ||
|
||
|
||
|
||
|
||
if(TARGET ocv.3rdparty.win32ui) | ||
if("win32ui" IN_LIST HIGHGUI_PLUGIN_LIST OR HIGHGUI_PLUGIN_LIST STREQUAL "all") | ||
ocv_create_builtin_highgui_plugin(opencv_highgui_win32 ocv.3rdparty.win32ui "window_w32.cpp") | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CMake variable
HAVE_FRAMEBUFFER
is not set anywhere, so our verification process will fail (seeENABLE_CONFIG_VERIFICATION
description (https://docs.opencv.org/4.x/db/d05/tutorial_config_reference.html#autotoc_md913).Maybe we should use more strict condition targeting not UNIX in general, but Linux specifically. E.g.
UNIX AND NOT APPLE AND NOT ANDROID
maybe evenCMAKE_SYSTEM_NAME EQUAL "Linux"
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommended restrictions added