Feat/svg converter #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cactooz
approved these changes
Dec 28, 2024
.github/workflows/generate-png.yml
Outdated
|
|
||
| - name: Install imagemagick | ||
| run: | | ||
| sudo apt-get install imagemagick |
There was a problem hiding this comment.
As you are using ubuntu-latest, I would use apt instead of apt-get as it's the new and more reliable version.
.github/workflows/generate-png.yml
Outdated
|
|
||
| printf "\rProgress: [%${filled}s%${unfilled}s] %d%%" "$(printf '#%.0s' $(seq 1 $filled))" "$(printf ' %.0s' $(seq 1 $unfilled))" "$percentage" | ||
| png_file="${file%.svg} 4k.png" | ||
| convert -background none -density 700 "$file" -quality 100 -resize 4000 "$png_file" |
There was a problem hiding this comment.
Density of 700 seems quite high. Shouldn't this be 72 for digital things or 300 if we want to be safe for print? Lowering this would probably also reduce the file sizes.
epicmeme
force-pushed
the
feat/svg-converter
branch
from
9851b5d to
7e3cc65
Compare
epicmeme
force-pushed
the
feat/svg-converter
branch
from
bf77732 to
7c31e5f
Compare
epicmeme
force-pushed
the
feat/svg-converter
branch
from
e0f998e to
86b3f68
Compare
epicmeme
force-pushed
the
feat/svg-converter
branch
from
af0f67c to
4d3b678
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.