Add more Author tags for consistent formatting #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cactooz
force-pushed
the
author-tag-expansion
branch
from
8562362 to
190a4a3
Compare
Cactooz
force-pushed
the
author-tag-expansion
branch
from
190a4a3 to
b111991
Compare
StelFoog
reviewed
Mar 21, 2025
Cactooz
force-pushed
the
author-tag-expansion
branch
3 times, most recently
from
37f13b4 to
9d5b9a2
Compare
Cactooz
force-pushed
the
author-tag-expansion
branch
from
9d5b9a2 to
dce10bb
Compare
Cactooz
added a commit
that referenced
this pull request
Mar 23, 2025
* Add more author metadata tags and update songs with new layout * Add test for invalid author fields * Update README with new author metadata tags * Bump version to 2.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a new
Authortype with name, event, location, year and a comment in order to format all author tags the same way. The new type gets formatted into the following formatName (Event, Location, Year - Comment)and saved to the existing author tag for the song when building the songs.I did not implement separate first, last and nicknames as well as the program as I felt it was enough to write that in the name field to not make the
Authortype too complex to fill.As this is a breaking change for song format, the version gets bumped to 2.0.0. However, the output from songs.json/xml will still be the same and is backwards compatible with the old format, so songbooks that use them will not have to update anything.
When going through the songs and updating to the new layout, I also updated the missing author information for some songs.
Resolves #9