Issue26 manually trimming video #31
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Added the new metod to enable the users to manually control the positions of the trimming.
-Added 2 new private methods getMiddleXPointForLeftOverlayViewWithTime and getMiddleXPointForRightOverlayViewWithTime the 2 methods calculate the positions of the left and right thumb views given a start and end time respectively. -Implemented the setVideoBounds method the method validates the inputs (start and end time) then the method uses the 2 new private methods getMiddleXPointForLeftOverlayViewWithTime and getMiddleXPointForRightOverlayViewWithTime to calculate the new position of the thumb views then then the method notifies the delegate of the changes, in case the method fails to validate the input it immediately returns without noitifing the delegate.
-The action of the "Change position" shows a UIAlertController view with 2 textFields start and end time then passes the inputs to the setVideoBounds method.
-Changed the keyboard of the 2 textfields on the alert to be UIKeyboardTypeDecimalPad. -Added a check on the input string to check if the input string in empty and if so a default value is set.
Author
|
@itsmeichigo hey are you going to look at this PR?, it has been more than 4 months now |
Owner
|
Hi, sorry I have been caught up with other stuff so I sort of forgot about this. Will review it as soon as I can. Thanks |
Owner
|
Hi, I test with this video and it doesn't seem right to me. There are a lot of issues:
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request solves this issue, the pull request has the following changes:
Added a new "Change position" button the the main view, when clicking the button an alert is shown with 2 textFields start and end time.
Added a new "setVideoBoundsToStartTime:endTime" method to the ICGVideoTrimmerView class, this method takes 2 parameters, start and end time, by calling this method the user can change the trimming of the video manually without dragging the thumb views; This method validates the inputs and if the validation fails the method returns immediately and if not the method calculates the new positions based on the start and end time and then notifies the delegate.