Use mc-image-helper to install vanilla Minecraft.

[jcotton42]

This is a prerequsitive for #1818, and uses mc-image-helper for the vanilla install logic.

This PR will remain in draft until its prerequisite itzg/mc-image-helper#812 is merged.

[itzg]

You could go ahead and bump the version here rather than waiting on Renovate and a merge

docker-minecraft-server/Dockerfile

Line 60 in cd2c562

ARG MC_HELPER_VERSION=1.61.4

[jcotton42]

You could go ahead and bump the version here rather than waiting on Renovate and a merge

Done.

[itzg]

Thanks! I’ll merge this in the morning.

[jcotton42]

Not sure why the tests are failing. I can investigate in the morning.

I'll admit I didn't run the full test suite, but my own simple tests with the container passed just fine :/

[itzg]

I'll re-run the tests also. Sometimes there's a slight race condition in the container startup during GitHub actions run.

[itzg]

Oh...I'll get your changes ported to the java8 branch of mc-image-helper

https://github.com/itzg/docker-minecraft-server/actions/runs/29667080574/job/88202414097?pr=4165

[jcotton42]

I didn't even think about the java 8 branch, whoops.

[itzg]

Also brings in itzg/mc-image-helper#818

[itzg]

I forgot too until that was the one variant was still failing 😄