fix: resolve GTNH server packs from versions.json#4170
Closed
WowSuchRicky wants to merge 2 commits into
Closed
Conversation
Author
|
Apologies this should have still been a draft. Will reopen at another time or resubmit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix GTNH server-pack discovery against the current
downloads.gtnewhorizons.com/versions.jsonmetadata endpoint.Changes
GTNH_PACK_VERSION=latest-dev.maxJavaVersionand reject missing/non-HTTPS server URLs.Reproduction
The container's GTNH startup path must resolve server files from
versions.json. The implementation must not produce the previousServer files not foundfailure forlatest-devor exact versions.Validation
bash -n scripts/start-deployGTNH tests/gtnh-versions-json/test.shshellcheck -x scripts/start-deployGTNHshellcheck tests/gtnh-versions-json/test.shtests/gtnh-versions-json/test.shgit diff --checkThe repository-wide Docker test harness was not runnable locally because Docker is unavailable; please use CI for the full integration gate.