Fix login start packet decoding for 1.18.2 up to 1.20.2#421
Merged
Conversation
itzg
reviewed
Jun 29, 2025
itzg
left a comment
itzg
left a comment
Owner
There was a problem hiding this comment.
Awesome!
Just the additional inline reference links and I'm good to merge. I know you already have them later in protocol list, but will help inline.
Signed-off-by: Fred Heinecke <fred.heinecke@yahoo.com>
Signed-off-by: solidDoWant <fred.heinecke@yahoo.com>
solidDoWant
force-pushed
the
fix/login-start-1.18.2-forward-1
branch
from
June 29, 2025 06:45
3bef4a0 to
c50a377
Compare
Owner
|
This is released in https://github.com/itzg/mc-router/releases/tag/1.32.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the project can only properly decode login start packets for 1.20.2 forward. The expected format of this packet has changed several times in the preceding releases:
Because of this, parsing player info for versions older than 1.20.2 fails, causing other features like webhooks and allow/deny lists to fail.
This adds version-dependent parsing logic to the login start packet parser. This should now parsing packets for most non-beta MC packets, if not all.