-
Notifications
You must be signed in to change notification settings - Fork 154
Fix user and group ID #251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
It's a security best practice. Refer to the contributing PR and issue Besides, those are just defaults. Set those values as you need during deploy time. |
By "it" you mean using Regarding defaults, shouldn't it be safe AND working by default? I will double check if anything else could be the reason for this not working with csi-nfs |
@uhthomas sorry to ping you after a 2 year old PR, but can you comment on the points brought up here? |
This is the first I'm hearing that the values there don't work by default. I don't use any of these charts myself, so I personally can't speak to the usability of the defaults. |
I have a suspicion that this is the fault of cni-nfs, I'll keep you posted |
The values shouldn't really matter, or even make a difference. They are distinct to illustrate that they represent different things, and because it seems to be a good thing to do generally. Changing these values all to 1000 is unlikely to help unless the underlying storage is already using group 1000, in which case the Helm values file can be configured. I think the reasoning of keeping these values distinct is demonstrated quite well even here, the ID of the user, group and fs group are not related. A value of 1000 for all of them could incorrectly suggest correlation. |
I think the current values can't work, and they don't work when using nfs-csi: