Skip to content

Comments

feat: add nameOverride and fullnameOverride to minecraft chart#253

Merged
billimek merged 2 commits intoitzg:masterfrom
joryirving:feat/fullnameoverride-minecraft
Mar 15, 2025
Merged

feat: add nameOverride and fullnameOverride to minecraft chart#253
billimek merged 2 commits intoitzg:masterfrom
joryirving:feat/fullnameoverride-minecraft

Conversation

@joryirving
Copy link
Contributor

Adds nameOverride and fullnameOverride to the chart/helpers, as per the mc-router chart.

Closes #252

@billimek
Copy link
Collaborator

Thanks @joryirving! Can you please bump the chart version in Chart.yaml such that the new version is 4.25.0 given that this is a new feature?

@billimek billimek merged commit 4ebd86d into itzg:master Mar 15, 2025
1 check passed
@janpfischer
Copy link

Since this change I get the following error message when trying to deploy the new chart version:

'Helm upgrade failed for release selfhosted/minecraft with chart minecraft@4.26.1:
      template: minecraft/templates/_helpers.tpl:32:14: executing "minecraft.fullname"
      at <.Values.fullnameOverride>: nil pointer evaluating interface {}.fullnameOverride'

I do not set a fullname in my values. I believe it has something to do with nameOverwrite and fullNameOverwrite are set to "" in values.yaml per default and the logic in the if-clauses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Request: add fullnameOverride to minecraft Helm chart

3 participants