feat: add nameOverride and fullnameOverride to minecraft chart#253
Merged
billimek merged 2 commits intoitzg:masterfrom Mar 15, 2025
joryirving:feat/fullnameoverride-minecraft
Merged
feat: add nameOverride and fullnameOverride to minecraft chart#253billimek merged 2 commits intoitzg:masterfrom joryirving:feat/fullnameoverride-minecraft
billimek merged 2 commits intoitzg:masterfrom
joryirving:feat/fullnameoverride-minecraft
Conversation
Collaborator
|
Thanks @joryirving! Can you please bump the chart version in |
billimek
approved these changes
Mar 15, 2025
|
Since this change I get the following error message when trying to deploy the new chart version: I do not set a fullname in my values. I believe it has something to do with nameOverwrite and fullNameOverwrite are set to "" in values.yaml per default and the logic in the if-clauses. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
nameOverrideandfullnameOverrideto the chart/helpers, as per the mc-router chart.Closes #252