Skip to content

OCI chart release #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 20, 2025
Merged

OCI chart release #256

merged 11 commits into from
Mar 20, 2025

Conversation

joryirving
Copy link
Contributor

@joryirving joryirving commented Mar 16, 2025

Update the release pipeline to continue to push to the ghcr helm repository, as well as push an OCI image and sign it.

This also cleans up the chart.version reference using a template.
This publishes the objects as ghcr.io/itzg/minecraft-server-charts/<chartname>

Successful run: https://github.com/joryirving/minecraft-server-charts/actions/runs/13891040259/job/38862979875

OCI artifact for mc-router: https://github.com/joryirving/minecraft-server-charts/pkgs/container/minecraft-server-charts%2Fmc-router
OCI artifact for minecraft: https://github.com/joryirving/minecraft-server-charts/pkgs/container/minecraft-server-charts%2Fminecraft

I've tested it successfully in my own cluster, and the changes to chart-version work.

Unfortunately, I couldn't get cosign working:
https://github.com/joryirving/minecraft-server-charts/actions/runs/13890798966/job/38862394740#step:11:21

Closes #254

@joryirving joryirving force-pushed the feat/oci-chart-release branch from 2e65133 to 2f6db61 Compare March 17, 2025 03:01
@joryirving joryirving marked this pull request as ready for review March 17, 2025 03:40
Copy link
Owner

@itzg itzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is ready to merge...and do its thing? If so, I'll merge it.

@@ -8,42 +8,45 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v2
uses: actions/checkout@v4
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This makes me realize I need dependabot enabled on this repo.

@joryirving
Copy link
Contributor Author

It should be ready to roll! The only validation I wasn't sure on, is if you wanted the charts bumped to a different version.

I'm currently running mc-router and minecraft charts built using this in my own repo, successfully.

@itzg
Copy link
Owner

itzg commented Mar 20, 2025

The only validation I wasn't sure on, is if you wanted the charts bumped to a different version.

Like a patch version bump instead of minor? I was fine with either.

@joryirving
Copy link
Contributor Author

Great! Then it should be good to go.

@itzg itzg merged commit acfd854 into itzg:master Mar 20, 2025
1 check passed
@itzg
Copy link
Owner

itzg commented Mar 20, 2025

@joryirving
Copy link
Contributor Author

joryirving commented Mar 21, 2025

Looks good to me! The only thing is that it's based on your previous helm release chart logic, so it will only publish when the version is bumped, so only 2/5 are published right now. I'm not sure if you want to do a dummy bump for the rest of the charts.

@itzg
Copy link
Owner

itzg commented Mar 21, 2025

Yeah, I inherited all that chart version release behavior from when the repo got migrated into my github org.

I'll bump those chart versions to get the release going.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: Upload Helm chart to OCI registry
2 participants