-
Notifications
You must be signed in to change notification settings - Fork 154
OCI chart release #256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCI chart release #256
Conversation
2e65133
to
2f6db61
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This is ready to merge...and do its thing? If so, I'll merge it.
@@ -8,42 +8,45 @@ jobs: | |||
runs-on: ubuntu-latest | |||
steps: | |||
- name: Checkout | |||
uses: actions/checkout@v2 | |||
uses: actions/checkout@v4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. This makes me realize I need dependabot enabled on this repo.
It should be ready to roll! The only validation I wasn't sure on, is if you wanted the charts bumped to a different version. I'm currently running |
Like a patch version bump instead of minor? I was fine with either. |
Great! Then it should be good to go. |
How does that build look: https://github.com/itzg/minecraft-server-charts/actions/runs/13981301196/job/39146916051 |
Looks good to me! The only thing is that it's based on your previous helm release chart logic, so it will only publish when the version is bumped, so only 2/5 are published right now. I'm not sure if you want to do a dummy bump for the rest of the charts. |
Yeah, I inherited all that chart version release behavior from when the repo got migrated into my github org. I'll bump those chart versions to get the release going. |
Update the release pipeline to continue to push to the ghcr helm repository, as well as push an OCI image and sign it.
This also cleans up the chart.version reference using a template.
This publishes the objects as
ghcr.io/itzg/minecraft-server-charts/<chartname>
Successful run: https://github.com/joryirving/minecraft-server-charts/actions/runs/13891040259/job/38862979875
OCI artifact for mc-router: https://github.com/joryirving/minecraft-server-charts/pkgs/container/minecraft-server-charts%2Fmc-router
OCI artifact for minecraft: https://github.com/joryirving/minecraft-server-charts/pkgs/container/minecraft-server-charts%2Fminecraft
I've tested it successfully in my own cluster, and the changes to chart-version work.
Unfortunately, I couldn't get cosign working:
https://github.com/joryirving/minecraft-server-charts/actions/runs/13890798966/job/38862394740#step:11:21
Closes #254