Skip to content

hotfix: allow rendering extra port services #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 28, 2025
Merged

hotfix: allow rendering extra port services #259

merged 2 commits into from
Mar 28, 2025

Conversation

d3adb5
Copy link
Contributor

@d3adb5 d3adb5 commented Mar 28, 2025

When using .Values.minecraftServer.extraPorts with the Service resource
enabled and not embedded, template rendering is failing due to the invocation of
minecraft.fullname with the context being . instead of $.

This effectively fixes it.

Minimal values file to reproduce the issue on 4.26.0:

minecraftServer:
  extraPorts:
    - name: voice-chat
      containerPort: 24454
      service:
        enabled: true
        embedded: false
        port: 24454

Running a helm template with this results in the following error:

Error: template: minecraft/templates/_helpers.tpl:32:14: executing "minecraft.fullname" at <.Values.fullnameOverride>: nil pointer evaluating interface {}.fullnameOverride

d3adb5 added 2 commits March 28, 2025 11:19
@d3adb5
hotfix: fix rendering of extra port services
2577d77 
Fix rendering of extra port services, previously broken due to an
invocation of the "minecraft.fullname" partial on a local context within
a range loop.
@d3adb5
chore: bump minecraft chart version to 4.26.1
cc4b192 
Bump chart version accordingly.
@itzg itzg added the bug Something isn't working label Mar 28, 2025
itzg
itzg approved these changes Mar 28, 2025
View reviewed changes
Copy link
Owner

@itzg itzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@itzg itzg merged commit 7ce7466 into itzg:master Mar 28, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itzg itzg itzg approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d3adb5 @itzg