Update values.schema.json for mc-router #261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update values.schema.json for mc-router
|
The change looks great. Thanks. Please also bump the chart version to satisfy the build verification. |
Changed pushed @itzg . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prometheus metrics are available from the application itself: https://github.com/itzg/mc-router/blob/master/cmd/mc-router/metrics.go#L31C8-L31C18
If you use this value in the helmchart, helm will fail during validation as it's not allowed in the schema.
Helm upgrade failed for release default/minecraft-router with chart [email protected]+556b89e29b95: values don't meet the specifications of the schema(s) in the following chart(s): mc-router: - minecraftRouter.metrics.backend: minecraftRouter.metrics.backend must be one of the following: "discard", "expvar", "influxdb"