Skip to content

fix: add catch for nil value #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 10, 2025
Merged

fix: add catch for nil value #263

merged 2 commits into from
Apr 10, 2025

Conversation

joryirving
Copy link
Contributor

Add's guard for nil value for nameOverride and fullnameOverride

Fixes #262

Copy link
Owner

@itzg itzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding the guard seems like a decent solution, but it seems like the root cause must be something like a missing root/$ context anchor somewhere. Perhaps since you can't recreate the reported issue then it's finding a needle in the haystack?

@joryirving
Copy link
Contributor Author

Yes, without being able to reproduce it, all I have is the shared error message, and this might be a fix for it.

Copy link
Owner

@itzg itzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following on this BTW.

@itzg itzg merged commit 74b6716 into itzg:master Apr 10, 2025
1 check passed
@joryirving joryirving deleted the patch-1 branch April 10, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not providing fullNameOverride to minecraft chart is failing helm deployment
2 participants