Skip to content

mc-router: use consistent image tag default #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2025
Merged

mc-router: use consistent image tag default #265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions charts/mc-router/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
apiVersion: v1
name: mc-router
version: 1.2.6
appVersion: 1.20.0
version: 1.3.0
# not used
appVersion: 1.0.0
home: https://github.com/itzg/mc-router
description: Routes Minecraft client connections to backend servers based upon the requested server address.
keywords:
Expand Down
2 changes: 1 addition & 1 deletion charts/mc-router/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ spec:
- name: {{ .Chart.Name }}
securityContext:
{{- toYaml .Values.securityContext | nindent 12 }}
image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
image: "{{ .Values.image.repository }}:{{ .Values.image.tag }}"
imagePullPolicy: {{ .Values.image.pullPolicy }}
env:
{{- include "mc-router.envMap" (list "IN_KUBE_CLUSTER" "true") }}
Expand Down
5 changes: 2 additions & 3 deletions charts/mc-router/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,8 @@ replicaCount: 1

image:
repository: itzg/mc-router
pullPolicy: IfNotPresent
# Overrides the image tag whose default is the chart appVersion.
tag: ""
tag: latest
pullPolicy: Always

imagePullSecrets: []
nameOverride: ""
Expand Down