Add opt-in startupProbe to minecraft-bedrock #277
+20
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial start-up of the pod can be slow, especially when doing an upgrade with a slow filesystem. Rather than increasing the
initialDelaySecondson the liveness/readiness probes, the recommended approach would be to use a startup probe.I added a
startupProbethat defaults to disabled (as I didn't want to presumptively change existing behavior). The startup probe has a default failure time of 10m (60 failures @ 10s intervals) and copies theinitialDelaySecondsof the existing liveness and readiness probes.Hopefully this is useful to someone else, and let me know if you want any changes!