Skip to content

Update Kemal to 1.6.0 and remove Kilt#5120

Merged
syeopite merged 1 commit intoiv-org:masterfrom
syeopite:update-kemal
May 18, 2025
Merged

Update Kemal to 1.6.0 and remove Kilt#5120
syeopite merged 1 commit intoiv-org:masterfrom
syeopite:update-kemal

Conversation

@syeopite
Copy link
Copy Markdown
Member

Kilt is unmaintained and the ECR templating logic has been natively integrated into Kemal with the issues previously seen having been resolved.

This commit is mostly a precursor to support the next Kemal release which will add the ability to create error handlers for raised exceptions.

See kemalcr/kemal#688

@syeopite syeopite added the need-testing This feature needs to be deployed and tested to see if it's working, and doesn't break something label Dec 19, 2024
@syeopite syeopite requested a review from a team as a code owner December 19, 2024 21:25
@syeopite syeopite requested review from unixfox and removed request for a team December 19, 2024 21:25
@syeopite
Copy link
Copy Markdown
Member Author

Looks like we'll need to drop support for Crystal versions prior to 1.12.X

@SamantazFox
Copy link
Copy Markdown
Member

I recall that we had a lot of templating issues when Kemal removed kilt. Even though it uses the stdlib's ECR.render function under the hood, removing kilt was breaking everything. Might be worth to try again, though.

Btw, your addition of error handlers to Kemal is very cool :)

@syeopite
Copy link
Copy Markdown
Member Author

Yeah those templating issues seem to have been resolved. On my side I didn't notice any problems during testing

Kilt is unmaintained and the ECR templating logic has been
natively integrated into Kemal with the issues previously seen
having been resolved.

This commit is mostly a precursor to support the next Kemal
release which will add the ability to create error handlers for
raised exceptions.

See kemalcr/kemal#688
@syeopite syeopite added ready and removed need-testing This feature needs to be deployed and tested to see if it's working, and doesn't break something labels Mar 14, 2025
@syeopite syeopite merged commit df41cb9 into iv-org:master May 18, 2025
8 checks passed
@syeopite syeopite deleted the update-kemal branch May 18, 2025 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants