-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Feature: Reply Counts #5168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Feature: Reply Counts #5168
Conversation
hey @AHOHNMYC @ChunkyProgrammer, could you please take a look at this PR for the JS side? thank you :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't tested but I have this one comment
hello @ChunkyProgrammer, could do a final check in order to see if it is ok? thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@unixfox Code LGTM
It also LGTM on the video page and community page
Here are some screenshots:
Initial look:
after opening replies (top)
after opening replies (bottom)
after loading all the comments:
Comment count change:
before loading all:
after loading all:
Community page:
I don't see how the (x/x) is useful. I would keep "view x replies" loaded or not. |
I personally like the prospect where with long comment chains you can know how far you have read into a comment's long thread of replies (characteristic of the first couple of comments due to popularity ranking) after initially collapsing the comment and then returning to the top of the comment section to find that same comment. I can modify the counter to only display the final count i.e. (40) vs (40/40) when all the comments are loaded. |
Maybe do that in a "title" attribute? It's displayed on hover |
Added to both title and sub text (for mobile users) |
Fractions are read as left to right in RTL languages: |
Productivity feature: include reply counts for both the "load more" and show/hide replies buttons.
Easily tested this through browser dev tools since all source code changes were purely JavaScript, so this PR can be expedited.