Skip to content

Feature: Reply Counts #5168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

epicsam123
Copy link
Contributor

@epicsam123 epicsam123 commented Feb 2, 2025

Productivity feature: include reply counts for both the "load more" and show/hide replies buttons.

Easily tested this through browser dev tools since all source code changes were purely JavaScript, so this PR can be expedited.

@epicsam123 epicsam123 requested a review from a team as a code owner February 2, 2025 02:10
@epicsam123 epicsam123 requested review from SamantazFox and removed request for a team February 2, 2025 02:10
@unixfox
Copy link
Member

unixfox commented Feb 3, 2025

hey @AHOHNMYC @ChunkyProgrammer, could you please take a look at this PR for the JS side? thank you :D

Copy link
Contributor

@ChunkyProgrammer ChunkyProgrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested but I have this one comment

@unixfox
Copy link
Member

unixfox commented Mar 29, 2025

hello @ChunkyProgrammer, could do a final check in order to see if it is ok? thanks.

Copy link
Contributor

@ChunkyProgrammer ChunkyProgrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@unixfox Code LGTM

It also LGTM on the video page and community page

Here are some screenshots:

Initial look:

image

after opening replies (top)

image

after opening replies (bottom)

image

after loading all the comments:

image

Comment count change:

before loading all:

image

after loading all:

image

Community page:

image

@Minecon724
Copy link

I don't see how the (x/x) is useful. I would keep "view x replies" loaded or not.

@epicsam123
Copy link
Contributor Author

I don't see how the (x/x) is useful. I would keep "view x replies" loaded or not.

I personally like the prospect where with long comment chains you can know how far you have read into a comment's long thread of replies (characteristic of the first couple of comments due to popularity ranking) after initially collapsing the comment and then returning to the top of the comment section to find that same comment. I can modify the counter to only display the final count i.e. (40) vs (40/40) when all the comments are loaded.

@Minecon724
Copy link

I don't see how the (x/x) is useful. I would keep "view x replies" loaded or not.

I personally like the prospect where with long comment chains you can know how far you have read into a comment's long thread of replies (characteristic of the first couple of comments due to popularity ranking) after initially collapsing the comment and then returning to the top of the comment section to find that same comment. I can modify the counter to only display the final count i.e. (40) vs (40/40) when all the comments are loaded.

Maybe do that in a "title" attribute? It's displayed on hover
Either way I suggest making it clearer like "(40/40 loaded)"

@epicsam123
Copy link
Contributor Author

I don't see how the (x/x) is useful. I would keep "view x replies" loaded or not.

I personally like the prospect where with long comment chains you can know how far you have read into a comment's long thread of replies (characteristic of the first couple of comments due to popularity ranking) after initially collapsing the comment and then returning to the top of the comment section to find that same comment. I can modify the counter to only display the final count i.e. (40) vs (40/40) when all the comments are loaded.

Maybe do that in a "title" attribute? It's displayed on hover Either way I suggest making it clearer like "(40/40 loaded)"

Added to both title and sub text (for mobile users)

@epicsam123
Copy link
Contributor Author

Fractions are read as left to right in RTL languages:
https://en.wikipedia.org/wiki/Modern_Arabic_mathematical_notation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants